From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzUox-0006wi-JK for qemu-devel@nongnu.org; Mon, 01 Jun 2015 14:52:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzUou-0007G3-DT for qemu-devel@nongnu.org; Mon, 01 Jun 2015 14:52:23 -0400 Received: from mail-qg0-x22f.google.com ([2607:f8b0:400d:c04::22f]:32933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzUou-0007Fx-9R for qemu-devel@nongnu.org; Mon, 01 Jun 2015 14:52:20 -0400 Received: by qgfa63 with SMTP id a63so50957596qgf.0 for ; Mon, 01 Jun 2015 11:52:19 -0700 (PDT) Sender: Richard Henderson Message-ID: <556CA9DE.4000205@twiddle.net> Date: Mon, 01 Jun 2015 11:52:14 -0700 From: Richard Henderson MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 17/34] HACK: globalise TCG page size variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Peter Crosthwaite , Alex Williamson , pbonzini@redhat.com, edgar.iglesias@gmail.com, afaerber@suse.de On 05/30/2015 11:11 PM, Peter Crosthwaite wrote: > This is almost certainly wrong but it should work for my test case > where TARGET_PAGE_SIZE is cross-arch consistent. This is needed to get > vfio/pci.c to compile due to it's use of HOST_PAGE_ALIGN. > > Cc: Alex Williamson > Signed-off-by: Peter Crosthwaite > --- > translate-all.c | 4 ---- > translate-common.c | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) Actually, this isn't a hack at all, since here we're talking about the HOST page size. Which is of course completely independent of the TARGET page sizes. r~