From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzUxD-0007IT-Td for qemu-devel@nongnu.org; Mon, 01 Jun 2015 15:00:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzUx9-0001X6-9N for qemu-devel@nongnu.org; Mon, 01 Jun 2015 15:00:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzUx8-0001Wn-TG for qemu-devel@nongnu.org; Mon, 01 Jun 2015 15:00:51 -0400 Message-ID: <556CABDB.4080309@redhat.com> Date: Mon, 01 Jun 2015 13:00:43 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433184977-20001-1-git-send-email-kallan@suse.com> <1433184977-20001-2-git-send-email-kallan@suse.com> In-Reply-To: <1433184977-20001-2-git-send-email-kallan@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LqaNlVmmes6VjQhpCEo4oCtcoaixtI5Xc" Subject: Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirk Allan , qemu-devel@nongnu.org Cc: okrishtal@parallels.com, mdroth@linux.vnet.ibm.com, sw@weilnetz.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LqaNlVmmes6VjQhpCEo4oCtcoaixtI5Xc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/01/2015 12:56 PM, Kirk Allan wrote: > Test if =E2=80=93-extra-cflags is being used to include flags such as Something in your workflow is substituting UTF-8 characters instead of ASCII '-'. s/=E2=80=93-/--/ > _WIN32_WINVER and WINVER to gain additional functionality offered > by Windows Vista/2008 and newer. If not, default WINVER to 0x501. >=20 > Add the iphlpapi library to use APIs such as GetAdaptersInfo and > GetAdaptersAddresses. >=20 > Signed-off-by: Kirk Allan > --- > configure | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/configure b/configure > index 4e2f78a..67bd9af 100755 > --- a/configure > +++ b/configure > @@ -708,7 +708,12 @@ fi > if test "$mingw32" =3D "yes" ; then > EXESUF=3D".exe" > DSOSUF=3D".dll" > - QEMU_CFLAGS=3D"-DWIN32_LEAN_AND_MEAN -DWINVER=3D0x501 $QEMU_CFLAGS" > + # --extra-cflags can be used to set flags such as -DWINVER and > + # -D_WIN32_WINNT. If -DWINVER has not be set, default to XP (0x501)= =2E s/be/been/ However, I'm not all that fluent in Windows compilation, so I'll let others do the actual technical review. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LqaNlVmmes6VjQhpCEo4oCtcoaixtI5Xc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVbKvbAAoJEKeha0olJ0Nq1MEIAKdGpsFN78NvMOtqdV2ZNlnD 8u2H6Bv20VsSIsNTVfwiFBbynSnZa/oc+HlvnUBvxTL4ZSqv+lS4o6AmW+qksNFV 7Z0korE9Xuotq0e6pQqvVFVNtPr1TE2qkgFKLlQ/M7BvcOg/YbCZFUMSSl4l7SHl rkIaa+UMiCYrijWz+vcTrJw+gHb2tOhw9tZ+y9i84kJD1mAZHDZK04+zyBkbc7SQ FWT3mOfXDhaqyI+zG5K9J6/TEb2qTsbeNtSij3vfswrBJVepQmqNo7NBwB58+3Lj JXDlahlql62Jk/st7gxHWkkiT2FKjCTrPMdVXASPkfWsS7iCWpq1oVScOCFHsh0= =sm/4 -----END PGP SIGNATURE----- --LqaNlVmmes6VjQhpCEo4oCtcoaixtI5Xc--