From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YzV6J-0004bc-NI
	for qemu-devel@nongnu.org; Mon, 01 Jun 2015 15:10:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YzV6G-0004sV-II
	for qemu-devel@nongnu.org; Mon, 01 Jun 2015 15:10:19 -0400
Received: from mail-qc0-x236.google.com ([2607:f8b0:400d:c01::236]:36820)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YzV6G-0004sP-DZ
	for qemu-devel@nongnu.org; Mon, 01 Jun 2015 15:10:16 -0400
Received: by qcxw10 with SMTP id w10so51411559qcx.3
	for <qemu-devel@nongnu.org>; Mon, 01 Jun 2015 12:10:16 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <556CAE14.6010209@twiddle.net>
Date: Mon, 01 Jun 2015 12:10:12 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <cover.1433052532.git.crosthwaite.peter@gmail.com>
	<e1d683c36fbc39779c618bd921a75339845d35c3.1433052532.git.crosthwaite.peter@gmail.com>
In-Reply-To: <e1d683c36fbc39779c618bd921a75339845d35c3.1433052532.git.crosthwaite.peter@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v2 03/34] Makefile.target: Introduce arch-obj
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: edgar.iglesias@gmail.com, Peter Crosthwaite <crosthwaite.peter@gmail.com>, pbonzini@redhat.com, afaerber@suse.de, peter.maydell@linaro.org

On 05/30/2015 11:11 PM, Peter Crosthwaite wrote:
>  #########################################################
>  # cpu emulator library
> -obj-y = exec.o translate-all.o cpu-exec.o
> -obj-y += tcg/tcg.o tcg/tcg-op.o tcg/optimize.o
> +obj-y += exec.o
> +arch-obj-$(call lnot,$(TARGET_MULTI)) += translate-all.o
> +arch-obj-$(call lnot,$(TARGET_MULTI)) += cpu-exec.o
> +arch-obj-$(call lnot,$(TARGET_MULTI)) += tcg/tcg.o tcg/tcg-op.o tcg/optimize.o
>  obj-$(CONFIG_TCG_INTERPRETER) += tci.o
>  obj-$(CONFIG_TCG_INTERPRETER) += disas/tci.o
>  obj-y += fpu/softfloat.o
> -obj-y += target-$(TARGET_BASE_ARCH)/
> +obj-$(CONFIG_ARCH_SINGLE) += target-$(TARGET_BASE_ARCH)/
> +arch-obj-$(CONFIG_ARCH_MULTI) += target-$(TARGET_BASE_ARCH)/
> +obj-$(CONFIG_ARCH_MULTI) += target-$(TARGET_BASE_ARCH)/hw/
>  obj-y += disas.o
>  obj-$(call notempty,$(TARGET_XML_FILES)) += gdbstub-xml.o
>  obj-$(call lnot,$(CONFIG_KVM)) += kvm-stub.o
> @@ -132,7 +136,8 @@ obj-y += arch_init.o cpus.o monitor.o gdbstub.o balloon.o ioport.o numa.o
>  obj-y += qtest.o bootdevice.o
>  obj-y += hw/
>  obj-$(CONFIG_KVM) += kvm-all.o
> -obj-y += memory.o savevm.o cputlb.o
> +obj-y += memory.o savevm.o
> +arch-obj-$(call lnot,$(TARGET_MULTI)) += cputlb.o
>  obj-y += memory_mapping.o
>  obj-y += dump.o
>  LIBS := $(libs_softmmu) $(LIBS)

How does translate-all.o get built for CONFIG_ARCH_SINGLE?

Is arch-obj-n added to obj-y somewhere I'm missing?  Such an inclusion would
seem to tidy some of the lines above...


r~