qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <rth@twiddle.net>,
	Peter Crosthwaite <crosthwaitepeter@gmail.com>,
	qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, edgar.iglesias@gmail.com,
	afaerber@suse.de, Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [RFC v2 10/34] include/exec: Split target_long def to new header
Date: Mon, 01 Jun 2015 21:51:58 +0200	[thread overview]
Message-ID: <556CB7DE.1080006@redhat.com> (raw)
In-Reply-To: <556CB18A.6070305@twiddle.net>



On 01/06/2015 21:24, Richard Henderson wrote:
> On 05/30/2015 11:11 PM, Peter Crosthwaite wrote:
>> This is currently provided by cpu-defs and is a target specific
>> definition. However, to prepare for multi-arch only the bare minimum
>> content from cpu-defs.h should be exported to core code. And this is
>> all we need. So split it to a new header that the target_multi cpu.h
>> can include to save on having to include the ill-defined cpu-defs.h.
>>
>> Allow multiple inclusion for multi-arch where multiple cpu.h's need
>> to be included and target_long will vary for each.
>>
>> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
>> ---
>>  include/exec/cpu-defs.h    | 23 +-------------------
>>  include/exec/target-long.h | 52 ++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 53 insertions(+), 22 deletions(-)
>>  create mode 100644 include/exec/target-long.h
> 
> Multiple inclusion with a typedef?  How's that supposed to work?

He later #defines target_{,u}long to e.g. arm_target_{,u}long.

Paolo

  reply	other threads:[~2015-06-01 19:52 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-31  6:11 [Qemu-devel] [RFC v2 00/34] Multi Architecture System Emulation Peter Crosthwaite
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 01/34] cpu-defs: Move CPU_TEMP_BUF_NLONGS to tcg Peter Crosthwaite
2015-06-01 18:57   ` Richard Henderson
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 02/34] cpu-exec: Purge all uses of CPU_GET_ENV Peter Crosthwaite
2015-06-01 19:03   ` Richard Henderson
2015-06-07 22:57     ` Peter Crosthwaite
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 03/34] Makefile.target: Introduce arch-obj Peter Crosthwaite
2015-06-01 19:10   ` Richard Henderson
2015-06-02  9:40     ` Peter Crosthwaite
2015-06-02 10:34       ` Paolo Bonzini
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 04/34] cpu-exec: Migrate some generic fns to cpus.c Peter Crosthwaite
2015-06-01  7:45   ` Paolo Bonzini
2015-07-10  6:37     ` Peter Crosthwaite
2015-06-01 19:12   ` Richard Henderson
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 05/34] translate: Listify tcg_exec_init Peter Crosthwaite
2015-06-01 19:17   ` Richard Henderson
2015-07-10 10:15   ` Peter Crosthwaite
2015-07-11  9:16     ` Peter Crosthwaite
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 06/34] cpu-common: Define tb_page_addr_t for everyone Peter Crosthwaite
2015-06-01  7:51   ` Paolo Bonzini
2015-06-07 23:06     ` Peter Crosthwaite
2015-06-24  9:48       ` Paolo Bonzini
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.h Peter Crosthwaite
2015-06-01 19:18   ` Richard Henderson
2015-06-24  9:11   ` Paolo Bonzini
2015-06-24 11:40     ` Pavel Dovgaluk
2015-06-24 11:41       ` Paolo Bonzini
2015-06-24 11:59         ` Pavel Dovgaluk
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 08/34] translate-all: Move tcg_handle_interrupt to -common Peter Crosthwaite
2015-06-01 19:20   ` Richard Henderson
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 09/34] include/exec: Move standard exceptions to cpu-all.h Peter Crosthwaite
2015-06-01 19:20   ` Richard Henderson
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 10/34] include/exec: Split target_long def to new header Peter Crosthwaite
2015-06-01 19:24   ` Richard Henderson
2015-06-01 19:51     ` Paolo Bonzini [this message]
2015-06-01 20:25       ` Peter Maydell
2015-06-01 20:27         ` Paolo Bonzini
2015-06-01 20:32       ` Richard Henderson
2015-06-01 20:39         ` Paolo Bonzini
2015-06-02 10:14         ` Peter Crosthwaite
2015-06-03 10:01           ` Paolo Bonzini
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 11/34] include/exec: Move cputlb exec.c defs out Peter Crosthwaite
2015-06-01  7:56   ` Paolo Bonzini
2015-06-02  9:44     ` Peter Crosthwaite
2015-06-02 10:38       ` Paolo Bonzini
2015-06-01 19:25   ` Richard Henderson
2015-06-24  9:25   ` Paolo Bonzini
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 12/34] include/exec: Move tb hash functions out Peter Crosthwaite
2015-06-01  7:56   ` Paolo Bonzini
2015-06-01 19:25   ` Richard Henderson
2015-06-24  9:05   ` Paolo Bonzini
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 13/34] cpu-defs: Move out TB_JMP defines Peter Crosthwaite
2015-06-01 19:25   ` Richard Henderson
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 14/34] cpu-defs: Allow multiple inclusions Peter Crosthwaite
2015-06-01  7:59   ` Paolo Bonzini
2015-06-01 19:29     ` Richard Henderson
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 15/34] HACK: monitor: Comment out TCG profile ops Peter Crosthwaite
2015-06-01  8:03   ` Paolo Bonzini
2015-06-01 18:49     ` Richard Henderson
2015-07-11 20:26     ` Peter Crosthwaite
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 16/34] HACK: Disable list_cpus Peter Crosthwaite
2015-06-01  8:04   ` Paolo Bonzini
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 17/34] HACK: globalise TCG page size variables Peter Crosthwaite
2015-06-01 18:52   ` Richard Henderson
2015-06-01 18:58     ` Peter Crosthwaite
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 18/34] HACK: monitor: uninclude cpu_ldst Peter Crosthwaite
2015-07-09  3:08   ` Peter Crosthwaite
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 19/34] HACK: disas: Defeature print_target_address Peter Crosthwaite
2015-06-01  8:08   ` Paolo Bonzini
2015-06-01 18:55   ` Richard Henderson
2015-06-08  0:21     ` Peter Crosthwaite
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 20/34] HACK: exec: comment out use of cpu_get_tb_cpu_from_state Peter Crosthwaite
2015-06-01  8:09   ` Paolo Bonzini
2015-06-08  0:22     ` Peter Crosthwaite
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 21/34] core: virtualise CPU interfaces completely Peter Crosthwaite
2015-06-01  8:11   ` Paolo Bonzini
2015-06-02  9:52     ` Peter Crosthwaite
2015-06-02 10:38       ` Paolo Bonzini
2015-06-01 19:53   ` Richard Henderson
2015-06-02  9:56     ` Peter Crosthwaite
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 22/34] microblaze: enable multi-arch Peter Crosthwaite
2015-06-01  8:16   ` Paolo Bonzini
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 23/34] arm: cpu: static inline cpu_arm_init Peter Crosthwaite
2015-06-01  8:18   ` Paolo Bonzini
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 24/34] target-arm: Split cp helper API to new C file Peter Crosthwaite
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 25/34] arm: enable multi-arch Peter Crosthwaite
2015-06-01  8:22   ` Paolo Bonzini
2015-05-31  6:11 ` [Qemu-devel] [RFC v2 26/34] core: Introduce multi-arch build Peter Crosthwaite
2015-06-01  8:26   ` Paolo Bonzini
2015-05-31  6:12 ` [Qemu-devel] [RFC v2 27/34] hw: arm: Explicitly include cpu.h for consumers Peter Crosthwaite
2015-05-31  6:12 ` [Qemu-devel] [RFC v2 28/34] arm: Remove ELF_MACHINE from cpu.h Peter Crosthwaite
2015-06-01  8:39   ` Paolo Bonzini
2015-05-31  6:12 ` [Qemu-devel] [RFC v2 29/34] hw: mb: Explicitly include cpu.h for consumers Peter Crosthwaite
2015-05-31  6:12 ` [Qemu-devel] [RFC v2 30/34] mb: Remove ELF_MACHINE from cpu.h Peter Crosthwaite
2015-05-31  6:12 ` [Qemu-devel] [RFC v2 31/34] arm: boot: Don't assume all CPUs are ARM Peter Crosthwaite
2015-05-31  6:12 ` [Qemu-devel] [RFC v2 32/34] arm: xilinx_zynq: Add a Microblaze Peter Crosthwaite
2015-05-31  6:12 ` [Qemu-devel] [RFC v2 33/34] HACK: mb: boot: Assume using -firmware for mb software Peter Crosthwaite
2015-05-31  6:12 ` [Qemu-devel] [RFC v2 34/34] HACK: mb: boot: Disable dtb load in multi-arch Peter Crosthwaite
2015-06-01  8:44 ` [Qemu-devel] [RFC v2 00/34] Multi Architecture System Emulation Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556CB7DE.1080006@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=crosthwaite.peter@gmail.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).