From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzW2h-0005D7-36 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 16:10:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzW2d-00016e-1q for qemu-devel@nongnu.org; Mon, 01 Jun 2015 16:10:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzW2c-00016H-SQ for qemu-devel@nongnu.org; Mon, 01 Jun 2015 16:10:34 -0400 Message-ID: <556CBC38.8030603@redhat.com> Date: Mon, 01 Jun 2015 16:10:32 -0400 From: John Snow MIME-Version: 1.0 References: <1432881807-18164-1-git-send-email-edgar.iglesias@gmail.com> <1432881807-18164-2-git-send-email-edgar.iglesias@gmail.com> In-Reply-To: <1432881807-18164-2-git-send-email-edgar.iglesias@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 01/15] target-arm: Correct check for non-EL3 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" , qemu-devel@nongnu.org, peter.maydell@linaro.org Cc: edgar.iglesias@xilinx.com, serge.fdrv@gmail.com, alex.bennee@linaro.org, agraf@suse.de On 05/29/2015 02:43 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" >=20 > Signed-off-by: Edgar E. Iglesias > --- > target-arm/op_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c > index 3f5b9ab..7583ae7 100644 > --- a/target-arm/op_helper.c > +++ b/target-arm/op_helper.c > @@ -421,7 +421,7 @@ void HELPER(access_check_cp_reg)(CPUARMState *env, = void *rip, uint32_t syndrome) > /* Requesting a trap to EL2 when we're in EL3 or S-EL0/1 is > * a bug in the access function. > */ > - assert(!arm_is_secure(env) && !arm_current_el(env) =3D=3D 3); > + assert(!arm_is_secure(env) && arm_current_el(env) !=3D 3); > target_el =3D 2; > break; > case CP_ACCESS_TRAP_EL3: >=20 This patch could even be liberated from this series if it hasn't been already, since the clang build is currently broken with -Werror without this fix. Reviewed-by: John Snow