From: Paolo Bonzini <pbonzini@redhat.com>
To: Kirk Allan <kallan@suse.com>, qemu-devel@nongnu.org
Cc: okrishtal@parallels.com, "Alex Bennée" <alex.bennee@linaro.org>,
mdroth@linux.vnet.ibm.com, sw@weilnetz.de
Subject: Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries
Date: Mon, 01 Jun 2015 22:24:11 +0200 [thread overview]
Message-ID: <556CBF6B.2060202@redhat.com> (raw)
In-Reply-To: <1433184977-20001-2-git-send-email-kallan@suse.com>
On 01/06/2015 20:56, Kirk Allan wrote:
> Test if –-extra-cflags is being used to include flags such as
> _WIN32_WINVER and WINVER to gain additional functionality offered
> by Windows Vista/2008 and newer. If not, default WINVER to 0x501.
>
> Add the iphlpapi library to use APIs such as GetAdaptersInfo and
> GetAdaptersAddresses.
>
> Signed-off-by: Kirk Allan <kallan@suse.com>
Elsewhere on the list, we've discussed putting extra cflags _after_ the
configure-detected QEMU_CFLAGS. This would fix the issue in the first
part of this patch too.
Is iphlpapi available on Windows XP?
Paolo
> ---
> configure | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 4e2f78a..67bd9af 100755
> --- a/configure
> +++ b/configure
> @@ -708,7 +708,12 @@ fi
> if test "$mingw32" = "yes" ; then
> EXESUF=".exe"
> DSOSUF=".dll"
> - QEMU_CFLAGS="-DWIN32_LEAN_AND_MEAN -DWINVER=0x501 $QEMU_CFLAGS"
> + # --extra-cflags can be used to set flags such as -DWINVER and
> + # -D_WIN32_WINNT. If -DWINVER has not be set, default to XP (0x501).
> + if [ "$QEMU_CFLAGS" = "${QEMU_CFLAGS%-DWINVER=*}" ] ; then
> + QEMU_CFLAGS="-DWINVER=0x501 $QEMU_CFLAGS"
> + fi
> + QEMU_CFLAGS="-DWIN32_LEAN_AND_MEAN $QEMU_CFLAGS"
> # enable C99/POSIX format strings (needs mingw32-runtime 3.15 or later)
> QEMU_CFLAGS="-D__USE_MINGW_ANSI_STDIO=1 $QEMU_CFLAGS"
> LIBS="-lwinmm -lws2_32 -liphlpapi $LIBS"
> @@ -724,7 +729,7 @@ if test "$mingw32" = "yes" ; then
> sysconfdir="\${prefix}"
> local_statedir=
> confsuffix=""
> - libs_qga="-lws2_32 -lwinmm -lpowrprof $libs_qga"
> + libs_qga="-lws2_32 -lwinmm -lpowrprof -liphlpapi $libs_qga"
> fi
>
> werror=""
>
next prev parent reply other threads:[~2015-06-01 20:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 18:56 [Qemu-devel] [PATCH v4 0/2] qga: qmp_guest_network_get_interfaces for win32 Kirk Allan
2015-06-01 18:56 ` [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries Kirk Allan
2015-06-01 19:00 ` Eric Blake
2015-06-01 20:24 ` Paolo Bonzini [this message]
2015-06-01 21:19 ` Kirk Allan
2015-06-02 14:08 ` Paolo Bonzini
2015-06-02 15:30 ` Kirk Allan
2015-06-02 19:41 ` Paolo Bonzini
2015-06-01 18:56 ` [Qemu-devel] [PATCH v4 2/2] qga: win32 implementation of qmp_guest_network_get_interfaces Kirk Allan
2015-06-01 19:02 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556CBF6B.2060202@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kallan@suse.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=okrishtal@parallels.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).