From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzWOP-00066a-Qj for qemu-devel@nongnu.org; Mon, 01 Jun 2015 16:33:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzWOM-00085Q-JM for qemu-devel@nongnu.org; Mon, 01 Jun 2015 16:33:05 -0400 Received: from mail-pd0-x231.google.com ([2607:f8b0:400e:c02::231]:34904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzWOM-00085F-DH for qemu-devel@nongnu.org; Mon, 01 Jun 2015 16:33:02 -0400 Received: by pdbnf5 with SMTP id nf5so54705277pdb.2 for ; Mon, 01 Jun 2015 13:33:01 -0700 (PDT) Sender: Richard Henderson Message-ID: <556CC179.3020400@twiddle.net> Date: Mon, 01 Jun 2015 13:32:57 -0700 From: Richard Henderson MIME-Version: 1.0 References: <74cc0d2f8d1d9d52638a1b3633e1a861b51907f4.1433052532.git.crosthwaite.peter@gmail.com> <556CB18A.6070305@twiddle.net> <556CB7DE.1080006@redhat.com> In-Reply-To: <556CB7DE.1080006@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 10/34] include/exec: Split target_long def to new header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, edgar.iglesias@gmail.com, afaerber@suse.de, Peter Crosthwaite On 06/01/2015 12:51 PM, Paolo Bonzini wrote: > > > On 01/06/2015 21:24, Richard Henderson wrote: >> On 05/30/2015 11:11 PM, Peter Crosthwaite wrote: >>> This is currently provided by cpu-defs and is a target specific >>> definition. However, to prepare for multi-arch only the bare minimum >>> content from cpu-defs.h should be exported to core code. And this is >>> all we need. So split it to a new header that the target_multi cpu.h >>> can include to save on having to include the ill-defined cpu-defs.h. >>> >>> Allow multiple inclusion for multi-arch where multiple cpu.h's need >>> to be included and target_long will vary for each. >>> >>> Signed-off-by: Peter Crosthwaite >>> --- >>> include/exec/cpu-defs.h | 23 +------------------- >>> include/exec/target-long.h | 52 ++++++++++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 53 insertions(+), 22 deletions(-) >>> create mode 100644 include/exec/target-long.h >> >> Multiple inclusion with a typedef? How's that supposed to work? > > He later #defines target_{,u}long to e.g. arm_target_{,u}long. Ok, here's where I'm not liking things. It shouldn't be a typedef in some places and a define others. From this description, it sounds like it ought to always be a define. r~