From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzYq0-0004GT-83 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 19:09:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzYpv-0007Ks-7d for qemu-devel@nongnu.org; Mon, 01 Jun 2015 19:09:44 -0400 Message-ID: <556CE630.4000308@redhat.com> Date: Mon, 01 Jun 2015 19:09:36 -0400 From: John Snow MIME-Version: 1.0 References: <1433102732-24034-1-git-send-email-mark.cave-ayland@ilande.co.uk> In-Reply-To: <1433102732-24034-1-git-send-email-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/4] macio: change DMA methods over to offset/len implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org On 05/31/2015 04:05 PM, Mark Cave-Ayland wrote: > This patchset follows on from my recent work on fixing issues with the > macio controller, and remodels the new pmac_dma_read() and pmac_dma_wri= te() > functions in a similar manner to the unaligned block functions. >=20 > With this in place, long chains of overlapping unaligned requests as us= ed > by OS X/Darwin will now work correctly without introducting torn sector > errors when writing to disk. >=20 > Also included are some tidy-ups as a result of the above changes. >=20 > Signed-off-by: Mark Cave-Ayland >=20 > Mark Cave-Ayland (4): > macio: switch pmac_dma_read() over to new offset/len implementation > macio: switch pmac_dma_write() over to new offset/len implementation > macio: update comment/constants to reflect the new code > macio: remove remainder_len DBDMA_io property >=20 > hw/ide/macio.c | 271 +++++++++++++++++-------------------= -------- > include/hw/ppc/mac_dbdma.h | 4 +- > 2 files changed, 105 insertions(+), 170 deletions(-) >=20 More 32/64bit printf string problems: macio.c:81: sector_num is int64_t (PRId64) macio.c:93: sector_num head_bytes is size_t (%zu) macio.c:107: sector_num tail_bytes is size_t (%zu) macio.c:147: sector_num macio.c:160: sector_num macio.c:178: sector_num But that's an unsatisfying response, so how about: Tested-by: John Snow Fixes the problem as far as I can tell. I'll comb it in a little more detail later. Have you tested this patchset with OSX et al to make sure it doesn't introduce any obvious regression on that side of things? Thanks! --js