From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45146)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1Yzi4w-0005oE-Eu
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 05:01:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1Yzi4r-00068M-Cw
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 05:01:46 -0400
Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]:36335)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1Yzi4r-000685-6O
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 05:01:41 -0400
Received: by laei3 with SMTP id i3so32538304lae.3
	for <qemu-devel@nongnu.org>; Tue, 02 Jun 2015 02:01:40 -0700 (PDT)
Message-ID: <556D70F1.6060708@gmail.com>
Date: Tue, 02 Jun 2015 12:01:37 +0300
From: Sergey Fedorov <serge.fdrv@gmail.com>
MIME-Version: 1.0
References: <1432810851-8648-1-git-send-email-serge.fdrv@gmail.com>
	<CAEgOgz5SxwXi+g57xCg_G=eMWG8h_Wmk1WDSqR4iM-7kjOSgAA@mail.gmail.com>
In-Reply-To: <CAEgOgz5SxwXi+g57xCg_G=eMWG8h_Wmk1WDSqR4iM-7kjOSgAA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-arm: use extended address bits from
 supersection short descriptor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

On 01.06.2015 21:41, Peter Crosthwaite wrote:
> On Thu, May 28, 2015 at 4:00 AM, Sergey Fedorov <serge.fdrv@gmail.com> wrote:
>> ---
>>  target-arm/helper.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/target-arm/helper.c b/target-arm/helper.c
>> index 5d0f011..fc3f192 100644
>> --- a/target-arm/helper.c
>> +++ b/target-arm/helper.c
>> @@ -5333,6 +5333,8 @@ static int get_phys_addr_v6(CPUARMState *env, uint32_t address, int access_type,
>>          if (desc & (1 << 18)) {
>>              /* Supersection.  */
>>              phys_addr = (desc & 0xff000000) | (address & 0x00ffffff);
>> +            phys_addr |= ((uint64_t)extract32(desc, 20, 4) << 32);
>> +            phys_addr |= ((uint64_t)extract32(desc, 5, 4) << 36);
> Outermost parentheses not needed.

Thanks, Peter. Will fix it v3.

Best,
Sergey

>
> Regards,
> Peter
>
>>              *page_size = 0x1000000;
>>          } else {
>>              /* Section.  */
>> --
>> 1.9.1
>>
>>