From: "Kővágó Zoltán" <dirty.ice.hu@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 05/12] audio: expose drv_opaque to init_out and init_in
Date: Tue, 02 Jun 2015 12:03:41 +0200 [thread overview]
Message-ID: <556D7F7D.9050403@gmail.com> (raw)
In-Reply-To: <1433231769.1637.19.camel@nilsson.home.kraxel.org>
2015-06-02 09:56 keltezéssel, Gerd Hoffmann írta:
>> -static int alsa_init_out (HWVoiceOut *hw, struct audsettings *as)
>> +static int alsa_init_out(HWVoiceOut *hw, struct audsettings *as,
>> + void *drv_opaque)
>> {
>> ALSAVoiceOut *alsa = (ALSAVoiceOut *) hw;
>> struct alsa_params_req req;
>> @@ -827,6 +828,8 @@ static int alsa_init_out (HWVoiceOut *hw, struct audsettings *as)
>> snd_pcm_t *handle;
>> struct audsettings obt_as;
>>
>> + (void) drv_opaque;
>> +
>
> What is the reason for this?
To silence compiler warnings about unused variables. I've seen it around
different places in the code. But if they are just historic remains,
I'll remove them.
Thanks,
Zoltan
next prev parent reply other threads:[~2015-06-02 10:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 13:23 [Qemu-devel] [PATCH 00/12] Audio backend cleanup Kővágó, Zoltán
2015-06-01 13:23 ` [Qemu-devel] [PATCH 01/12] audio: remove esd backend Kővágó, Zoltán
2015-06-01 13:23 ` [Qemu-devel] [PATCH 02/12] audio: remove fmod backend Kővágó, Zoltán
2015-06-01 13:23 ` [Qemu-devel] [PATCH 03/12] audio: remove sdl backend Kővágó, Zoltán
2015-06-01 13:23 ` [Qemu-devel] [PATCH 04/12] audio: remove winwave audio driver Kővágó, Zoltán
2015-06-01 13:23 ` [Qemu-devel] [PATCH 05/12] audio: expose drv_opaque to init_out and init_in Kővágó, Zoltán
2015-06-02 7:56 ` Gerd Hoffmann
2015-06-02 10:03 ` Kővágó Zoltán [this message]
2015-06-02 15:24 ` Gerd Hoffmann
2015-06-01 13:23 ` [Qemu-devel] [PATCH 06/12] alsaaudio: do not use global variables Kővágó, Zoltán
2015-06-01 13:23 ` [Qemu-devel] [PATCH 07/12] paaudio: " Kővágó, Zoltán
2015-06-01 13:23 ` [Qemu-devel] [PATCH 08/12] ossaudio: " Kővágó, Zoltán
2015-06-01 13:23 ` [Qemu-devel] [PATCH 09/12] wavaudio: " Kővágó, Zoltán
2015-06-01 13:23 ` [Qemu-devel] [PATCH 10/12] dsoundaudio: " Kővágó, Zoltán
2015-06-01 13:23 ` [Qemu-devel] [PATCH 11/12] paaudio: fix possible resource leak Kővágó, Zoltán
2015-06-01 13:23 ` [Qemu-devel] [PATCH 12/12] coreaudio: do not use global variables where possible Kővágó, Zoltán
2015-06-01 13:38 ` [Qemu-devel] [PATCH 00/12] Audio backend cleanup Michael Tokarev
2015-06-01 13:48 ` Kővágó Zoltán
2015-06-02 8:08 ` Gerd Hoffmann
2015-06-02 9:12 ` Michael Tokarev
2015-06-02 9:28 ` Gerd Hoffmann
2015-06-02 10:33 ` Paolo Bonzini
2015-06-02 10:45 ` Peter Maydell
2015-06-02 11:40 ` Michael Tokarev
2015-06-02 12:42 ` François Revol
2015-06-02 15:28 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556D7F7D.9050403@gmail.com \
--to=dirty.ice.hu@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).