From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzj2u-00023G-T4 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 06:03:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yzj2p-0002WI-Ng for qemu-devel@nongnu.org; Tue, 02 Jun 2015 06:03:44 -0400 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:37206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzj2p-0002WC-Gy for qemu-devel@nongnu.org; Tue, 02 Jun 2015 06:03:39 -0400 Received: by wifw1 with SMTP id w1so137970026wif.0 for ; Tue, 02 Jun 2015 03:03:38 -0700 (PDT) From: "=?UTF-8?B?S8WRdsOhZ8OzIFpvbHTDoW4=?=" Message-ID: <556D7F7D.9050403@gmail.com> Date: Tue, 02 Jun 2015 12:03:41 +0200 MIME-Version: 1.0 References: <1433231769.1637.19.camel@nilsson.home.kraxel.org> In-Reply-To: <1433231769.1637.19.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 05/12] audio: expose drv_opaque to init_out and init_in List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org 2015-06-02 09:56 keltezéssel, Gerd Hoffmann írta: >> -static int alsa_init_out (HWVoiceOut *hw, struct audsettings *as) >> +static int alsa_init_out(HWVoiceOut *hw, struct audsettings *as, >> + void *drv_opaque) >> { >> ALSAVoiceOut *alsa = (ALSAVoiceOut *) hw; >> struct alsa_params_req req; >> @@ -827,6 +828,8 @@ static int alsa_init_out (HWVoiceOut *hw, struct audsettings *as) >> snd_pcm_t *handle; >> struct audsettings obt_as; >> >> + (void) drv_opaque; >> + > > What is the reason for this? To silence compiler warnings about unused variables. I've seen it around different places in the code. But if they are just historic remains, I'll remove them. Thanks, Zoltan