From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzjab-0003ZG-70 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 06:38:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzjaV-0003nl-50 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 06:38:33 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:37443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzjaU-0003nW-V6 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 06:38:27 -0400 Received: by wifw1 with SMTP id w1so139055094wif.0 for ; Tue, 02 Jun 2015 03:38:26 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <556D879D.3050703@redhat.com> Date: Tue, 02 Jun 2015 12:38:21 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <26fe619f01abfe3bedd64733c0500b84675f3f44.1433052532.git.crosthwaite.peter@gmail.com> <556C1021.6030301@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 11/34] include/exec: Move cputlb exec.c defs out List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Peter Maydell , Peter Crosthwaite , "qemu-devel@nongnu.org Developers" , Peter Crosthwaite , "Edgar E. Iglesias" , =?UTF-8?B?QW5kcmVhcyBGw6Q=?= =?UTF-8?B?cmJlcg==?= , Richard Henderson On 02/06/2015 11:44, Peter Crosthwaite wrote: > On Mon, Jun 1, 2015 at 12:56 AM, Paolo Bonzini wrote: >> >> >> On 31/05/2015 08:11, Peter Crosthwaite wrote: >>> Move the architecture agnostic function prototypes for exec.c out of >>> cputlb.h to exec-all.h. This allows hiding of the arch specific >>> cputlb.h from exec.c which should be getting close to having no >>> architecture specifics. Prepares support for multi-arch, which will have >>> a minimal cpu.h that services exec.c but not cputlb.h. >>> >>> Signed-off-by: Peter Crosthwaite >> >> Since you are at it, tlb_protect_code/tlb_unprotect_code can also be >> moved to this new header (and to translate-common.c). > > Just a follow up patch? There is RB from Richard so would like to keep > it self contained. I can put this extra on the end of the "header" > series which I will split off from this series as the next non-RFC > component. Sure. Paolo