From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzmAT-0004N2-QI for qemu-devel@nongnu.org; Tue, 02 Jun 2015 09:23:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzmAQ-0000pm-LB for qemu-devel@nongnu.org; Tue, 02 Jun 2015 09:23:45 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:55260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzmAQ-0000pf-Ed for qemu-devel@nongnu.org; Tue, 02 Jun 2015 09:23:42 -0400 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 2 Jun 2015 07:23:41 -0600 Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 12A181FF004A for ; Tue, 2 Jun 2015 07:14:48 -0600 (MDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t52DLOZs35651768 for ; Tue, 2 Jun 2015 06:21:24 -0700 Received: from d03av05.boulder.ibm.com (localhost [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t52DNbUK029252 for ; Tue, 2 Jun 2015 07:23:37 -0600 Message-ID: <556DAE57.3060606@linux.vnet.ibm.com> Date: Tue, 02 Jun 2015 09:23:35 -0400 From: Stefan Berger MIME-Version: 1.0 References: <1433205175-1255386-1-git-send-email-stefanb@linux.vnet.ibm.com> <20150602084729-mutt-send-email-mst@redhat.com> <556DAC35.10307@linux.vnet.ibm.com> <20150602151740-mutt-send-email-mst@redhat.com> In-Reply-To: <20150602151740-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tpm: Add missing common TPM SSDT file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, stefanb@us.ibm.com On 06/02/2015 09:22 AM, Michael S. Tsirkin wrote: > On Tue, Jun 02, 2015 at 09:14:29AM -0400, Stefan Berger wrote: >> On 06/02/2015 02:48 AM, Michael S. Tsirkin wrote: >>> On Mon, Jun 01, 2015 at 08:32:55PM -0400, Stefan Berger wrote: >>>> This patch adds the missing common SSDT TPM file. >>>> >>>> Signed-off-by: Stefan Berger >>> I posted this too. But we really should just get rid of all this: we >>> have already removed most ASL code except for the DSDT. >> Yes, I will do that. Though for reviewing I think ASL is still easier to >> understand. >> >> Stefan > A bit, but once you get into more trickery, like you do with ifdefs > with QEMU-external TPM, it becomes less clear. > Those won't go away and will turn into case statements in C... stefan