From: Paolo Bonzini <pbonzini@redhat.com>
To: Kirk Allan <kallan@suse.com>, qemu-devel@nongnu.org
Cc: okrishtal@parallels.com, alex.bennee@linaro.org,
mdroth@linux.vnet.ibm.com, sw@weilnetz.de
Subject: Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries
Date: Tue, 02 Jun 2015 16:08:01 +0200 [thread overview]
Message-ID: <556DB8C1.8090605@redhat.com> (raw)
In-Reply-To: <556C7819020000760012FC6E@prv-mh.provo.novell.com>
On 01/06/2015 23:19, Kirk Allan wrote:
>> Elsewhere on the list, we've discussed putting extra cflags
>> _after_ the configure-detected QEMU_CFLAGS. This would fix the
>> issue in the first part of this patch too.
>
> By the time this portion of the configure script executes, any
> --extra-cflags have already been rolled into the QEMU_CFLAGS. Here
> I'm just checking if WINVER is already contained in QEMU_CFLAGS. If
> it is not, then add WINVER=0x501 to the flags as it was done before.
> If it's already contained in the QEMU_CFLAGS, just use what's there.
> The only ordering difference would be WINVER now comes before
> WIN32_LEAN_AND_MEAN.
If the extra cflags come last, they override the -DWINVER=0x501 that
configure adds, and this patch isn't necessary anymore.
Paolo
next prev parent reply other threads:[~2015-06-02 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 18:56 [Qemu-devel] [PATCH v4 0/2] qga: qmp_guest_network_get_interfaces for win32 Kirk Allan
2015-06-01 18:56 ` [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries Kirk Allan
2015-06-01 19:00 ` Eric Blake
2015-06-01 20:24 ` Paolo Bonzini
2015-06-01 21:19 ` Kirk Allan
2015-06-02 14:08 ` Paolo Bonzini [this message]
2015-06-02 15:30 ` Kirk Allan
2015-06-02 19:41 ` Paolo Bonzini
2015-06-01 18:56 ` [Qemu-devel] [PATCH v4 2/2] qga: win32 implementation of qmp_guest_network_get_interfaces Kirk Allan
2015-06-01 19:02 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556DB8C1.8090605@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kallan@suse.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=okrishtal@parallels.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).