From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzmrS-0000JM-No for qemu-devel@nongnu.org; Tue, 02 Jun 2015 10:08:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzmrO-0003Iu-Ta for qemu-devel@nongnu.org; Tue, 02 Jun 2015 10:08:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzmrO-0003Il-Oi for qemu-devel@nongnu.org; Tue, 02 Jun 2015 10:08:06 -0400 Message-ID: <556DB8C1.8090605@redhat.com> Date: Tue, 02 Jun 2015 16:08:01 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1433184977-20001-1-git-send-email-kallan@suse.com> <1433184977-20001-2-git-send-email-kallan@suse.com> <556CBF6B.2060202@redhat.com> <556C7819020000760012FC6E@prv-mh.provo.novell.com> In-Reply-To: <556C7819020000760012FC6E@prv-mh.provo.novell.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirk Allan , qemu-devel@nongnu.org Cc: okrishtal@parallels.com, alex.bennee@linaro.org, mdroth@linux.vnet.ibm.com, sw@weilnetz.de On 01/06/2015 23:19, Kirk Allan wrote: >> Elsewhere on the list, we've discussed putting extra cflags >> _after_ the configure-detected QEMU_CFLAGS. This would fix the >> issue in the first part of this patch too. > > By the time this portion of the configure script executes, any > --extra-cflags have already been rolled into the QEMU_CFLAGS. Here > I'm just checking if WINVER is already contained in QEMU_CFLAGS. If > it is not, then add WINVER=0x501 to the flags as it was done before. > If it's already contained in the QEMU_CFLAGS, just use what's there. > The only ordering difference would be WINVER now comes before > WIN32_LEAN_AND_MEAN. If the extra cflags come last, they override the -DWINVER=0x501 that configure adds, and this patch isn't necessary anymore. Paolo