Re: [Qemu-devel] [PATCH] configure: don't apply -O2 if extra-cflags sets -O

[Paolo Bonzini <pbonzini@redhat.com>]

On 02/06/2015 10:01, Alex Bennée wrote:
> 
> Michael Tokarev <mjt@tls.msk.ru> writes:
> 
>> 29.05.2015 19:29, Paolo Bonzini wrote:
>>> On 29/05/2015 16:14, Alex Bennée wrote:
>>>> You mean just do:
>>>>
>>>> diff --git a/configure b/configure
>>>> index b707429..f13831a 100755
>>>> --- a/configure
>>>> +++ b/configure
>>>> @@ -353,7 +353,7 @@ for opt do
>>>>    ;;
>>>>    --cpu=*) cpu="$optarg"
>>>>    ;;
>>>> -  --extra-cflags=*) QEMU_CFLAGS="$optarg $QEMU_CFLAGS"
>>>> +  --extra-cflags=*) QEMU_CFLAGS="$QEMU_CFLAGS $optarg"
>>>>                      EXTRA_CFLAGS="$optarg"
>>>>    ;;
>>>>    --extra-ldflags=*) LDFLAGS="$optarg $LDFLAGS"
>>>>
>>>> I guess at the time I was trying to be clean and avoiding multiple -O
>>>> calls. But I guess that will have the same effect.
>>>
>>> Yes, that.  Most other QEMU_CFLAGS assignments add at the beginning, so
>>> I guess the remaining ones (including the --extra-cflags one) should too.
>>
>> So, what's the final version of this patch?
> 
> I can send the second patch but I'm wary about changing all instances to
> QEMU_CFLAGS to append additional flags.

Sure, that's a separate change.

Paolo