From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56018)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YzmsF-0001BM-Ir
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 10:09:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YzmsC-0003SX-7v
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 10:08:59 -0400
Message-ID: <556DB8F3.3000204@redhat.com>
Date: Tue, 02 Jun 2015 16:08:51 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1432897012-1423-1-git-send-email-alex.bennee@linaro.org>
	<55684995.3070205@redhat.com> <877frrii83.fsf@linaro.org>
	<556893DB.9030502@redhat.com>
	<556D43C4.2070309@msgid.tls.msk.ru> <87vbf6bkua.fsf@linaro.org>
In-Reply-To: <87vbf6bkua.fsf@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] configure: don't apply -O2 if extra-cflags
	sets -O
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org



On 02/06/2015 10:01, Alex Benn=C3=A9e wrote:
>=20
> Michael Tokarev <mjt@tls.msk.ru> writes:
>=20
>> 29.05.2015 19:29, Paolo Bonzini wrote:
>>> On 29/05/2015 16:14, Alex Benn=C3=A9e wrote:
>>>> You mean just do:
>>>>
>>>> diff --git a/configure b/configure
>>>> index b707429..f13831a 100755
>>>> --- a/configure
>>>> +++ b/configure
>>>> @@ -353,7 +353,7 @@ for opt do
>>>>    ;;
>>>>    --cpu=3D*) cpu=3D"$optarg"
>>>>    ;;
>>>> -  --extra-cflags=3D*) QEMU_CFLAGS=3D"$optarg $QEMU_CFLAGS"
>>>> +  --extra-cflags=3D*) QEMU_CFLAGS=3D"$QEMU_CFLAGS $optarg"
>>>>                      EXTRA_CFLAGS=3D"$optarg"
>>>>    ;;
>>>>    --extra-ldflags=3D*) LDFLAGS=3D"$optarg $LDFLAGS"
>>>>
>>>> I guess at the time I was trying to be clean and avoiding multiple -=
O
>>>> calls. But I guess that will have the same effect.
>>>
>>> Yes, that.  Most other QEMU_CFLAGS assignments add at the beginning, =
so
>>> I guess the remaining ones (including the --extra-cflags one) should =
too.
>>
>> So, what's the final version of this patch?
>=20
> I can send the second patch but I'm wary about changing all instances t=
o
> QEMU_CFLAGS to append additional flags.

Sure, that's a separate change.

Paolo