From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YznZW-0001iZ-9m for qemu-devel@nongnu.org; Tue, 02 Jun 2015 10:53:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YznZS-0004UL-AS for qemu-devel@nongnu.org; Tue, 02 Jun 2015 10:53:42 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:37158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YznZS-0004UF-3Q for qemu-devel@nongnu.org; Tue, 02 Jun 2015 10:53:38 -0400 Received: by wifw1 with SMTP id w1so148134600wif.0 for ; Tue, 02 Jun 2015 07:53:37 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <556DC36E.1000907@redhat.com> Date: Tue, 02 Jun 2015 16:53:34 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20150602125634.GD19508@redhat.com> In-Reply-To: <20150602125634.GD19508@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Translation of strings in QEMU w/ gettext ? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org On 02/06/2015 14:56, Daniel P. Berrange wrote: > In my work on TLS encryption, I've been blindly adding gettext markers > around all error messages I raise. eg error_setg(errp, _("foo bar")); > I've done this out of habit, since most apps I work on translate all > strings that could end up visible by a user. > > Looking again at existing QEMU codebase though, I notice that adding > gettext _("...") markers is the exception, not the rule. I think that _("...") markers should remain the exceptions. However, we could autoextract for example error_setg/error_setg_errno's message arguments into PO files. Paolo