qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add .dir-locals.el file to configure emacs coding style
Date: Tue, 02 Jun 2015 10:02:26 -0600	[thread overview]
Message-ID: <556DD392.3040703@redhat.com> (raw)
In-Reply-To: <1433258768-28946-1-git-send-email-berrange@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

On 06/02/2015 09:26 AM, Daniel P. Berrange wrote:
> The default emacs setup indents by 2 spaces and uses tabs
> which is counter to the QEMU coding style rules. Adding a
> .dir-locals.el file in the top level of the GIT repo will
> inform emacs about the QEMU coding style, and so assist
> contributors in avoiding common style mistakes before
> they submit patches.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  .dir-locals.el | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 .dir-locals.el

Since we already have .exrc to do the same for vim users, I'm all in
favor of this.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2015-06-02 16:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02 15:26 [Qemu-devel] [PATCH] Add .dir-locals.el file to configure emacs coding style Daniel P. Berrange
2015-06-02 16:02 ` Eric Blake [this message]
2015-06-02 19:08   ` John Snow
2015-06-03  7:47 ` Markus Armbruster
2015-06-04 13:30   ` Daniel P. Berrange
2015-06-04 17:45     ` [Qemu-devel] [Qemu-trivial] " Don Slutz
2015-06-04 17:46     ` Don Slutz
2015-06-17 19:42 ` [Qemu-devel] " Michael Tokarev
2015-06-18  8:36   ` Markus Armbruster
2015-06-18  9:05     ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556DD392.3040703@redhat.com \
    --to=eblake@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).