From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzp2O-0005Lm-Lk for qemu-devel@nongnu.org; Tue, 02 Jun 2015 12:27:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yzp2J-0006ki-Ft for qemu-devel@nongnu.org; Tue, 02 Jun 2015 12:27:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzp2J-0006kc-Ac for qemu-devel@nongnu.org; Tue, 02 Jun 2015 12:27:31 -0400 Message-ID: <556DD971.70508@redhat.com> Date: Tue, 02 Jun 2015 10:27:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432908109-31559-1-git-send-email-sfeldma@gmail.com> <1432908109-31559-2-git-send-email-sfeldma@gmail.com> In-Reply-To: <1432908109-31559-2-git-send-email-sfeldma@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JFbW0U3xpn6ldoJSR6ipOINuUWowLJ9c2" Subject: Re: [Qemu-devel] [PATCH v3 1/4] rocker: Add support for phys name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com, qemu-devel@nongnu.org Cc: stefanha@gmail.com, jiri@resnulli.us, dsahern@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JFbW0U3xpn6ldoJSR6ipOINuUWowLJ9c2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/29/2015 08:01 AM, sfeldma@gmail.com wrote: > From: David Ahern >=20 > v2: >=20 > Review comment from Stefan Hajnoczi: >=20 > - use private ROCKER_IFNAMSIZ =3D 16 to avoid breaking Windows build > as Windows does not include >=20 > v1: >=20 > Add ROCKER_TLV_CMD_PORT_SETTINGS_PHYS_NAME to port settings. This attri= bute > exports the port name to the guest OS allowing it to name interfaces wi= th > sensible defaults. The above patch version information... >=20 > Mostly done by Scott for phys_id support; adapted to phys_name by David= =2E >=20 > Signed-off-by: Scott Feldman > Signed-off-by: David Ahern > --- =2E..belongs better here, after the --- separator. 'git am' strips off anything in this location, which makes for a nice separation: anything before the separator should be stand-alone, but things that are useful to list readers but not to permanent git history should be after the separator. After all, a year from now, we won't care if it took 1 or 10 versions on the list for the patch that got accepted, we will only care about the one version in git. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JFbW0U3xpn6ldoJSR6ipOINuUWowLJ9c2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVbdlxAAoJEKeha0olJ0NqZt0H/j8gKlvX9aYZHRjv0eGUpJGs e+1UQk5x+l5QxZgnF9DlAPJqcLU5D3sJ5ouYJEYYvgenDjAFqGi/Z74AvK37US4G tCltJLzBpKbvOyCAi1DsLvnLKDusuw4k5AuF8MThjZQOh5vd0HNtIwxA6JRQcXdm tbUcU45bGcy2rbJ4V+TMJIEaO/CfIQqUR48N0lfZpxLz2q6uIcj6ieOT0V6zHqWU mlfSB6VLaONDT9MKrABVqRx9dPW12DTjFERcSJgziL4mURYxzJZJmI7l9Hkea1YS z8Q1Bd8071/mahV3v5bJlfvO7HVcwsd3DVBarIM13ZJpYPFd/zcKbskIPTTD5kc= =eNue -----END PGP SIGNATURE----- --JFbW0U3xpn6ldoJSR6ipOINuUWowLJ9c2--