From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzp6n-0007Rr-R5 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 12:32:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yzp6i-0008Vm-Ow for qemu-devel@nongnu.org; Tue, 02 Jun 2015 12:32:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzp6i-0008Ve-Gk for qemu-devel@nongnu.org; Tue, 02 Jun 2015 12:32:04 -0400 Message-ID: <556DDA82.4000008@redhat.com> Date: Tue, 02 Jun 2015 10:32:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432908109-31559-1-git-send-email-sfeldma@gmail.com> <1432908109-31559-5-git-send-email-sfeldma@gmail.com> In-Reply-To: <1432908109-31559-5-git-send-email-sfeldma@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vvFIkIdWkVcS1apb8mhWBO6Xlhkx7gbre" Subject: Re: [Qemu-devel] [PATCH v3 4/4] qmp/hmp: add rocker device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com, qemu-devel@nongnu.org Cc: stefanha@gmail.com, jiri@resnulli.us, dsahern@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vvFIkIdWkVcS1apb8mhWBO6Xlhkx7gbre Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/29/2015 08:01 AM, sfeldma@gmail.com wrote: > From: Scott Feldman >=20 > v3: >=20 > Address review comments from Stefan Hajnoczi: >=20 > - Add missing hw/net/rocker/qmp-norocker.c file. > - Add missing curly brackets to a for loop >=20 > v2: >=20 > Address review comments from Stefan Hajnoczi: >=20 > - Add missing qapi/rocker.json file. > - Use PRIx64 for print uint64 value > - when CONFIG_ROCKER is not defined, build qmp-norocker.o stub using > hw/net/Makefile.objs rather than in the top-level Makefile.target >=20 > Change qapi/rocker.json "since 2.3" comments to "since 2.4", since qmp/= hmp > support didn't get into 2.3. >=20 > v1: Again, version info belongs after ---. >=20 > Add QMP/HMP support for rocker devices. This is mostly for debugging p= urposes > to see inside the device's tables and port configurations. Some exampl= es: >=20 > (qemu) info rocker sw1 > name: sw1 > id: 0x0000013512005452 > ports: 4 >=20 > (qemu) info rocker-ports sw1 > ena/ speed/ auto > port link duplex neg? > sw1.1 up 10G FD No > sw1.2 up 10G FD No > sw1.3 !ena 10G FD No > sw1.4 !ena 10G FD No >=20 > +++ b/qapi/rocker.json > +## > +# @rocker: This comment... > +# > +# Return rocker switch information. > +# > +# Returns: @Rocker information > +# > +# Since: 2.4 > +## > +{ 'command': 'query-rocker', =2E..does not match this command name. > + > +## > +# @rocker-ports: > +# > +# Return rocker switch information. > +# > +# Returns: @Rocker information > +# > +# Since: 2.4 > +## > +{ 'command': 'query-rocker-ports', and again. > + > +## > +# @rocker-of-dpa-flows: > +# > +# Return rocker OF-DPA flow information. > +# > +# @name: switch name > +# > +# @tbl-id: #optional flow table ID. If tbl-id is not specified, retur= ns > +# flow information for all tables. > +# > +# Returns: @Rocker OF-DPA flow information > +# > +# Since: 2.4 > +## > +{ 'command': 'query-rocker-of-dpa-flows', And again. > +## > +# @rocker-of-dpa-groups: > +# > +# Return rocker OF-DPA group information. > +# > +# @name: switch name > +# > +# @type: #optional group type. If type is not specified, returns > +# group information for all group types. > +# > +# Returns: @Rocker OF-DPA group information > +# > +# Since: 2.4 > +## > +{ 'command': 'query-rocker-of-dpa-groups', and again. > +++ b/qmp-commands.hx > +SQMP > +Show rocker switch ports > +------------------------ > + > +Arguments: > + > +- "name": switch name > + > +Example: > + > +-> { "execute": "query-rocker-ports", "arguments": { "name": "sw1" } }= > +<- { "return": [ {"duplex": "full", "enabled": true, "name": "sw1.1", = "autoneg": "off", "link-up": true, "speed": 10000}, > + {"duplex": "full", "enabled": true, "name": "sw1.2", = "autoneg": "off", "link-up": true, "speed": 10000} You might want to wrap these long lines. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vvFIkIdWkVcS1apb8mhWBO6Xlhkx7gbre Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVbdqCAAoJEKeha0olJ0NqPJAH+gMy8q4Iq//fWFbhNVvlnr8I I9ZLjc0E7dPEmfbuZNARk1O/Kjv2/scXviX7U8f/nduY8cR7BcpHjw9+uy1zOhmH vqt2x0eF1dgNcLOvNTtRMduu65d2Y0o4GIO/xIzFYAS0Yh34hwlAN3Vr5jJycoi7 w4R/93Der+IK4yhmC85ULN4rGdda4zFNYzSICzvCVNjPOnxNhzPmXFun79e5R2Xu oA7znixLrdG/sr10cvCtb06Bkl1/Opkr2n4MgqYyf5Rl45nqgjhjUUTVQok6PsDE T6wRTBrVUzuFYqOXG9TllvnoU2zeTFwZWioMALafEaE3rn/BRxqcLIYeFJKC9p4= =xhs1 -----END PGP SIGNATURE----- --vvFIkIdWkVcS1apb8mhWBO6Xlhkx7gbre--