From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzpG0-0000DK-Mj for qemu-devel@nongnu.org; Tue, 02 Jun 2015 12:41:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzpFv-000479-95 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 12:41:40 -0400 Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]:32879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzpFv-00046a-5L for qemu-devel@nongnu.org; Tue, 02 Jun 2015 12:41:35 -0400 Received: by qkhg32 with SMTP id g32so104147430qkh.0 for ; Tue, 02 Jun 2015 09:41:34 -0700 (PDT) Sender: Richard Henderson Message-ID: <556DDCBA.9090602@twiddle.net> Date: Tue, 02 Jun 2015 09:41:30 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1433193897-24110-1-git-send-email-aurelien@aurel32.net> <1433193897-24110-2-git-send-email-aurelien@aurel32.net> In-Reply-To: <1433193897-24110-2-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/13] target-s390x: fix exception for invalid operation code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org Cc: Alexander Graf On 06/01/2015 02:24 PM, Aurelien Jarno wrote: > When an operation code is not recognized (ie invalid instruction) an > operation exception should be generated instead of a specification > exception. The latter is for valid opcode, with invalid operands or > modifiers. > > This give a very basic GDB support in the guest, as it uses the invalid > opcode 0x0001 to generate a trap. > > Cc: Alexander Graf > Cc: Richard Henderson > Signed-off-by: Aurelien Jarno > --- > target-s390x/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~