From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzpKK-0000sW-24 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 12:46:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzpKF-00068h-Le for qemu-devel@nongnu.org; Tue, 02 Jun 2015 12:46:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzpKF-00068d-AH for qemu-devel@nongnu.org; Tue, 02 Jun 2015 12:46:03 -0400 Message-ID: <556DDDC1.9030204@redhat.com> Date: Tue, 02 Jun 2015 10:45:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433171851-18507-1-git-send-email-jjherne@linux.vnet.ibm.com> <1433171851-18507-3-git-send-email-jjherne@linux.vnet.ibm.com> <20150601153259.GK2314@work-vm> <556C936F.8090606@linux.vnet.ibm.com> <20150602135855.GC2139@work-vm> <556DBF9F.9000004@linux.vnet.ibm.com> In-Reply-To: <556DBF9F.9000004@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lhup1tm3Qmolc9EIuKKUs4Sb03g7xBLQC" Subject: Re: [Qemu-devel] [PATCH 2/2] migration: Dynamic cpu throttling for auto-converge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: jjherne@linux.vnet.ibm.com, "Dr. David Alan Gilbert" Cc: amit.shah@redhat.com, borntraeger@de.ibm.com, qemu-devel@nongnu.org, afaerber@suse.de, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lhup1tm3Qmolc9EIuKKUs4Sb03g7xBLQC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/02/2015 08:37 AM, Jason J. Herne wrote: >> >> Well, one thing you can do is add a parameter with a name starting >> with x- >> which means it's not a fixed interface (so things like libvirt wont >> use it). >> And the reason I was interested in seeing the information was otherwis= e >> we don't really have any way of knowing how well the code is working; >> is it already throttling down more and more? >> >=20 > Fair point. Can we add a qmp/hmp command like "info x-cpu-throttle"? Or= a > new line in "info migrate" output, "x-throttle-ration: 1.0" perhaps? > Would this mess up libvirt's parsing of the hmp/qmp data? Libvirt doesn't parse HMP data, and when parsing QMP data it gracefully ignores any fields it doesn't recognize (especially fields beginning with 'x-') (and if not, that's a bug to be fixed in libvirt). The QMP protocol even documents that clients MUST be prepared for new keys to appear in output. So this proposal should not cause any grief. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lhup1tm3Qmolc9EIuKKUs4Sb03g7xBLQC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVbd3BAAoJEKeha0olJ0Nqk50IAITbPOg3HGmS7xKT2A5iPxq/ QFDBaSehsa/HBaVdWZsqZVe87T0J5uVRVyd40d37jE9aIdbQsHt1V0+tPh0pXhC+ 8xc139Kfgr1KGlM/XebbaGGdUl3z1k3RsZg0rHS4dIhtL5tcA3CHpKDAkavuwBr8 pxobzG9Ts6iwGzItote79KSUi4UJTiXOOWN+VPmc0SoSY4u5hCA42rK5NsUkEaM5 uuPAaxFB98XXuFQReMgzQWuCYU1wRnYCdfwQkuSmjLpieO4NXx3ByfsXVyDH1fFk 5geIHEGeNKVPaYdJk5+3j3gVsE2tXVt+NIILTNjvS9691PTHKoJmgYbmFgI0hTY= =2NiU -----END PGP SIGNATURE----- --lhup1tm3Qmolc9EIuKKUs4Sb03g7xBLQC--