From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzs3m-0008Mh-St for qemu-devel@nongnu.org; Tue, 02 Jun 2015 15:41:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yzs3h-00089z-Qt for qemu-devel@nongnu.org; Tue, 02 Jun 2015 15:41:14 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:35491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzs3h-00089t-K4 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 15:41:09 -0400 Received: by wikd7 with SMTP id d7so23792859wik.0 for ; Tue, 02 Jun 2015 12:41:09 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <556E06CF.6040903@redhat.com> Date: Tue, 02 Jun 2015 21:41:03 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1433184977-20001-1-git-send-email-kallan@suse.com> <1433184977-20001-2-git-send-email-kallan@suse.com> <556CBF6B.2060202@redhat.com> <556C7819020000760012FC6E@prv-mh.provo.novell.com> <556DB8C1.8090605@redhat.com> <556D77CC020000760012FDBB@prv-mh.provo.novell.com> In-Reply-To: <556D77CC020000760012FDBB@prv-mh.provo.novell.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirk Allan , qemu-devel@nongnu.org Cc: okrishtal@parallels.com, alex.bennee@linaro.org, mdroth@linux.vnet.ibm.com, sw@weilnetz.de On 02/06/2015 17:30, Kirk Allan wrote: > I was assuming that if you set _WIN32_WINNT=0x0600 (needed to gain > access to the OnLinkPrefixLength field when running on Windows > Vista/2008 and greater) you would also want to set WINVER=0x600 to > match. Having WINVER in the flags as both 501 and 600 causes > configure errors. Hmm, right. It gives a "redefined" warning as if you had #define. And the warning is fatal. So Reviewed-by: Paolo Bonzini Paolo > Testing with _WIN32_WINNT=0x0600 and WINVER=0x501 seems to be ok.