From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzsTv-0000fv-6q for qemu-devel@nongnu.org; Tue, 02 Jun 2015 16:08:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzsTu-00016u-7r for qemu-devel@nongnu.org; Tue, 02 Jun 2015 16:08:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzsTu-00016a-3R for qemu-devel@nongnu.org; Tue, 02 Jun 2015 16:08:14 -0400 Message-ID: <556E0D25.10302@redhat.com> Date: Tue, 02 Jun 2015 14:08:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433267209-9882-1-git-send-email-jjherne@linux.vnet.ibm.com> <1433267209-9882-3-git-send-email-jjherne@linux.vnet.ibm.com> In-Reply-To: <1433267209-9882-3-git-send-email-jjherne@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="P6fvWlHn87cBEScn3hQB8rk04LtimxGIv" Subject: Re: [Qemu-devel] [PATCH v2 2/3] migration: Dynamic cpu throttling for auto-converge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Jason J. Herne" , afaerber@suse.de, amit.shah@redhat.com, dgilbert@redhat.com, borntraeger@de.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --P6fvWlHn87cBEScn3hQB8rk04LtimxGIv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/02/2015 11:46 AM, Jason J. Herne wrote: > Remove traditional auto-converge static 30ms throttling code and replac= e it > with a dynamic throttling algorithm. >=20 > Additionally, be more aggressive when deciding when to start throttling= =2E > Previously we waited until four unproductive memory passes. Now we begi= n > throttling after only two unproductive memory passes. Four seemed quite= > arbitrary and only waiting for two passes allows us to complete the mig= ration > faster. >=20 > Signed-off-by: Jason J. Herne > Reviewed-by: Matthew Rosato > --- > arch_init.c | 95 +++++++++++++++++--------------------------= -------- > migration/migration.c | 9 +++++ > 2 files changed, 41 insertions(+), 63 deletions(-) >=20 > +static void mig_throttle_guest_down(void) > +{ > + CPUState *cpu; > + > + CPU_FOREACH(cpu) { > + /* We have not started throttling yet. Lets start it.*/ s/Lets/Let's/ s|it.*/|it. */| > + if (!cpu_throttle_active(cpu)) { > + cpu_throttle_start(cpu, 0.2); > + } > + > + /* Throttling is already in place. Just increase the throttlin= g rate */ > + else { Unusual layout. More typical would be: if (...) { ... } else { /* comment */ ... } --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --P6fvWlHn87cBEScn3hQB8rk04LtimxGIv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVbg0lAAoJEKeha0olJ0NqrCkH/1g34XpqNhN67tAEqgn9FFua ySXdx1Zvxnu/x51AS3Ch0fm61jtHsNiOn1Hdnf15N8mh2wvAX7IV39YntflOMwJd P5AFkPyO7FZv4T7Bm0JIQnE3tQE4YMY/OKqUDR8Vb1l22hkRA2qAwNL/XfqxZif3 u+SdmY+rSS1dC3buHFzXivUKiDASDhIHmvIZ7tK9B4yuhcDZn//TESvATAq7VejG N/dT6FIt55kTVpXL/qmVQtgdsFoSbQ53qlwT7LfZHfFNEeQiCr8LJmHnLB/wsQK/ IC+EDzjV5rvDvJorQdFc6JL8Lb0PYJ3+q0l6hbUbm7NZ5EXbAgvkp21aJJYk0jI= =V0kb -----END PGP SIGNATURE----- --P6fvWlHn87cBEScn3hQB8rk04LtimxGIv--