From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzsXH-0002Yq-PX for qemu-devel@nongnu.org; Tue, 02 Jun 2015 16:11:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzsXE-0002ki-Ip for qemu-devel@nongnu.org; Tue, 02 Jun 2015 16:11:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzsXE-0002kX-DI for qemu-devel@nongnu.org; Tue, 02 Jun 2015 16:11:40 -0400 Message-ID: <556E0DFA.5070601@redhat.com> Date: Tue, 02 Jun 2015 14:11:38 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433267209-9882-1-git-send-email-jjherne@linux.vnet.ibm.com> <1433267209-9882-4-git-send-email-jjherne@linux.vnet.ibm.com> In-Reply-To: <1433267209-9882-4-git-send-email-jjherne@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hui73Iv0i0FNhb44InpIAIr9cRvjngmIi" Subject: Re: [Qemu-devel] [PATCH v2 3/3] qmp/hmp: Add throttle ratio to query-migrate and info migrate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Jason J. Herne" , afaerber@suse.de, amit.shah@redhat.com, dgilbert@redhat.com, borntraeger@de.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hui73Iv0i0FNhb44InpIAIr9cRvjngmIi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/02/2015 11:46 AM, Jason J. Herne wrote: > Report throttle ratio in info migrate and query-migrate responses when = cpu > throttling is active. >=20 > Signed-off-by: Jason J. Herne > --- > hmp.c | 5 +++++ > migration/migration.c | 5 +++++ > qapi-schema.json | 3 ++- > 3 files changed, 12 insertions(+), 1 deletion(-) >=20 > diff --git a/hmp.c b/hmp.c > index e17852d..cb3c137 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -229,6 +229,11 @@ void hmp_info_migrate(Monitor *mon, const QDict *q= dict) > info->xbzrle_cache->overflow); > } > =20 > + if (info->has_x_cpu_throttle_ratio) { > + monitor_printf(mon, "cpu throttle ratio : %0.2f\n", s/ :/:/ How big or small can the ratio get? Is %g going to be nicer than %f if the ratio goes through a large range of possibilities? > +++ b/qapi-schema.json > @@ -483,7 +483,8 @@ > '*total-time': 'int', > '*expected-downtime': 'int', > '*downtime': 'int', > - '*setup-time': 'int'} } > + '*setup-time': 'int', > + '*x-cpu-throttle-ratio': 'number'} } Even though it is marked experimental, it is still worth documenting this parameter, and include mention of how to interpret it (0.0 means no throttling, 1.0 means 50% duty cycle, 2.0 means 33% duty cycle, right?). Documentation should mention '(since 2.4)' --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hui73Iv0i0FNhb44InpIAIr9cRvjngmIi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVbg36AAoJEKeha0olJ0Nq8D8H/jzOT/bzARO6OWMBfTPLVMaP LaWjt9SYcGC32+nTzVjx2K/uq1YptBlRTpbL6kesM/SW3asFA6c8eW/ceMIVfkSn svHaBYsO38WvsXvOZGAaU9XYUqe7q2HQ0b+AOPtLCcR5Bausp3Y2J7Hd+8ulNZnf TSTOVOAr+xnGum9hQTKhKCH1HjMUlG7lFh2qPW8rSetNTxnZnOuqskJMXYdcQcgP RMn6jzbgL60KbTQJZSX+YHFG7hiiM1Z7oymMC+NJ5QMARK7qgm0b61sc2NJIQ3vO gFoZn+vrhQ7tDielp+dCYdi5R/y5Ow2GOw/neaPVgkfcrxFfhtJ+uBdii8QChic= =DgbF -----END PGP SIGNATURE----- --hui73Iv0i0FNhb44InpIAIr9cRvjngmIi--