From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42092)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YztGX-0001Dw-By
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 16:58:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YztGU-0008Ap-6t
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 16:58:29 -0400
Received: from mail-qg0-x230.google.com ([2607:f8b0:400d:c04::230]:32873)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YztGU-0008Al-2o
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 16:58:26 -0400
Received: by qgfa63 with SMTP id a63so64315432qgf.0
	for <qemu-devel@nongnu.org>; Tue, 02 Jun 2015 13:58:25 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <556E18ED.3070409@twiddle.net>
Date: Tue, 02 Jun 2015 13:58:21 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1433244411-9693-1-git-send-email-aurelien@aurel32.net>
	<1433244411-9693-4-git-send-email-aurelien@aurel32.net>
	<20150602201032.GA5379@aurel32.net>
In-Reply-To: <20150602201032.GA5379@aurel32.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC 3/5] softmmu: add a
	tlb_vaddr_to_host_fill function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Alexander Graf <agraf@suse.de>, Yongbok Kim <yongbok.kim@imgtec.com>, Paolo Bonzini <pbonzini@redhat.com>, Leon Alrae <leon.alrae@imgtec.com>, =?windows-1252?Q?Andreas_F=E4rber?= <afaerber@suse.de>

On 06/02/2015 01:10 PM, Aurelien Jarno wrote:
> It looks like we have to go through the MMIO functions to get the
> TLB_NOTDIRTY bit cleaned correctly. This is something we don't want for
> probe_write, so we definitely want two different functions.

I think that's why target-arm does it's somewhat convoluted loop in which it
stores one byte to the page and then tries again to use tlb_vaddr_to_host.

If the page isn't in the tlb, we perform a complete store and thus both pull
the page into the tlb as well as mark it dirty.  Thus if the page still isn't
present for the second vaddr_to_host, it really is I/O, or is being watched by
the debugger, or something equally unlikely.


r~