From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>,
Chen Gang <xili_gchen_5257@hotmail.com>
Cc: "walt@tilera.com" <walt@tilera.com>,
Chris Metcalf <cmetcalf@ezchip.com>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-devel <qemu-devel@nongnu.org>,
"rth@twiddle.net" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 05/10 v11] arget-tilegx/opcode_tilegx.h: Modify it to fit qemu using
Date: Wed, 03 Jun 2015 08:39:58 +0900 [thread overview]
Message-ID: <556E3ECE.9040600@suse.de> (raw)
In-Reply-To: <CAFEAcA8DKsMrYW9cD2cUMt9hDEs7v5n=WyKQFpzQKkp7hkearg@mail.gmail.com>
Am 03.06.2015 um 02:43 schrieb Peter Maydell:
> On 30 May 2015 at 22:14, Chen Gang <xili_gchen_5257@hotmail.com> wrote:
>> Use 'inline' instead of '__inline', and also use 'uint64_t' instead of
>> "unsigned long long"
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> target-tilegx/opcode_tilegx.h | 220 +++++++++++++++++++++---------------------
>> 1 file changed, 110 insertions(+), 110 deletions(-)
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
There's a "t" missing in the subject and the grammar is wrong - "usage"?
Also "QEMU".
Deserves a mention in the commit message why this is not being squashed.
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-06-02 23:40 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 21:07 [Qemu-devel] [PATCH 00/10 v11] tilegx: Firstly add tilegx target for linux-user Chen Gang
2015-05-30 21:10 ` [Qemu-devel] [PATCH 01/10 v11] linux-user: tilegx: Firstly add architecture related features Chen Gang
2015-06-02 17:06 ` Peter Maydell
2015-06-03 13:06 ` Chen Gang
2015-06-03 14:28 ` Peter Maydell
2015-05-30 21:10 ` [Qemu-devel] [PATCH 02/10 v11] linux-user: Support tilegx architecture in linux-user Chen Gang
2015-06-02 17:40 ` Peter Maydell
2015-06-03 12:30 ` Chen Gang
2015-06-03 12:34 ` Peter Maydell
2015-06-03 12:47 ` Chen Gang
2015-06-03 15:10 ` Chris Metcalf
2015-06-03 15:19 ` Peter Maydell
2015-06-03 15:20 ` Chris Metcalf
2015-06-04 12:25 ` Chen Gang
2015-06-04 12:29 ` Peter Maydell
2015-06-04 12:39 ` Chen Gang
2015-06-03 15:47 ` Richard Henderson
2015-06-04 12:32 ` Chen Gang
2015-07-07 0:19 ` Chris Metcalf
2015-07-07 20:47 ` Chen Gang
2015-07-07 20:50 ` Chen Gang
2015-07-08 19:24 ` Chris Metcalf
[not found] ` <559DC775.9080204@hotmail.com>
2015-07-09 1:09 ` gchen gchen
2015-05-30 21:12 ` [Qemu-devel] [PATCH 03/10 v11] linux-user/syscall.c: conditionalize syscalls which are not defined in tilegx Chen Gang
2015-06-02 17:41 ` Peter Maydell
2015-05-30 21:13 ` [Qemu-devel] [PATCH 04/10 v11] target-tilegx: Add opcode basic implementation from Tilera Corporation Chen Gang
2015-06-02 17:42 ` Peter Maydell
2015-05-30 21:14 ` [Qemu-devel] [PATCH 05/10 v11] arget-tilegx/opcode_tilegx.h: Modify it to fit qemu using Chen Gang
2015-06-02 17:43 ` Peter Maydell
2015-06-02 23:39 ` Andreas Färber [this message]
2015-06-03 11:59 ` Chen Gang
2015-05-30 21:15 ` [Qemu-devel] [PATCH 06/10 v11] target-tilegx: Add special register information from Tilera Corporation Chen Gang
2015-06-02 17:44 ` Peter Maydell
2015-06-02 20:52 ` Chen Gang
2015-06-02 20:53 ` Chen Gang
2015-05-30 21:15 ` [Qemu-devel] [PATCH 07/10 v11] target-tilegx: Add cpu basic features for linux-user Chen Gang
2015-06-02 17:51 ` Peter Maydell
2015-06-02 20:47 ` Chen Gang
2015-05-30 21:17 ` [Qemu-devel] [PATCH 08/10 v11] target-tilegx: Add several helpers for instructions translation Chen Gang
2015-06-01 16:02 ` Richard Henderson
2015-06-01 18:47 ` Chen Gang
2015-05-30 21:18 ` [Qemu-devel] [PATCH 09/10 v11] target-tilegx: Generate tcg instructions to finish "Hello world" Chen Gang
2015-06-01 18:40 ` Richard Henderson
2015-06-01 20:54 ` Chen Gang
2015-06-02 16:32 ` Richard Henderson
2015-06-02 21:30 ` Chen Gang
2015-06-07 22:20 ` Chen Gang
2015-06-02 17:54 ` Peter Maydell
2015-06-02 20:25 ` Chen Gang
2015-05-30 21:19 ` [Qemu-devel] [PATCH 10/10 v11] target-tilegx: Add TILE-Gx building files Chen Gang
2015-06-02 17:52 ` Peter Maydell
2015-06-02 20:26 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556E3ECE.9040600@suse.de \
--to=afaerber@suse.de \
--cc=cmetcalf@ezchip.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=walt@tilera.com \
--cc=xili_gchen_5257@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).