From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58046)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1Z05DX-0003A5-W6
	for qemu-devel@nongnu.org; Wed, 03 Jun 2015 05:44:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1Z05DU-00076r-PW
	for qemu-devel@nongnu.org; Wed, 03 Jun 2015 05:44:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43267)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1Z05DU-00076j-KS
	for qemu-devel@nongnu.org; Wed, 03 Jun 2015 05:44:08 -0400
Message-ID: <556ECC64.5000403@redhat.com>
Date: Wed, 03 Jun 2015 17:44:04 +0800
From: Jason Wang <jasowang@redhat.com>
MIME-Version: 1.0
References: <1422596933-11282-1-git-send-email-sebastian.huber@embedded-brains.de>
	<CAEgOgz5WcaooXL=sQv_QdSRrQ3H0++P=oaOHLK1tBVbjOsRkTQ@mail.gmail.com>
	<556EC148.7010503@embedded-brains.de>
In-Reply-To: <556EC148.7010503@embedded-brains.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] net: cadence_gem: Set initial MAC
	address
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>



On 06/03/2015 04:56 PM, Sebastian Huber wrote:
> Ping.
>
> Attached is a rebased version.

Hi. I believe you need post a formal inline V2 patch for this.

Thanks

>
> On 30/01/15 18:56, Peter Crosthwaite wrote:
>> On Thu, Jan 29, 2015 at 9:48 PM, Sebastian Huber
>> <sebastian.huber@embedded-brains.de> wrote:
>>> Set initial MAC address to the one specified by the command line.
>>>
>>> Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
>>> Reviewed-by: Jason Wang <jasowang@redhat.com>
>>>
>>> v2: Remove superfluous whitespace change.
>> The inter-spin change-logs should not go into commit messages. This
>> should be below the ---. With this removed (placed below the ---):
>>
>> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>>
>>> ---
>> Change-logs go here.
>>
>> Regards,
>> Peter
>>
>>>   hw/net/cadence_gem.c | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
>>> index de26609..f9a7af1 100644
>>> --- a/hw/net/cadence_gem.c
>>> +++ b/hw/net/cadence_gem.c
>>> @@ -1005,6 +1005,7 @@ static void gem_reset(DeviceState *d)
>>>   {
>>>       int i;
>>>       GemState *s = GEM(d);
>>> +    const uint8_t *a;
>>>
>>>       DB_PRINT("\n");
>>>
>>> @@ -1023,6 +1024,11 @@ static void gem_reset(DeviceState *d)
>>>       s->regs[GEM_DESCONF5] = 0x002f2145;
>>>       s->regs[GEM_DESCONF6] = 0x00000200;
>>>
>>> +    /* Set MAC address */
>>> +    a = &s->conf.macaddr.a[0];
>>> +    s->regs[GEM_SPADDR1LO] = a[0] | (a[1] << 8) | (a[2] << 16) |
>>> (a[3] << 24);
>>> +    s->regs[GEM_SPADDR1HI] = a[4] | (a[5] << 8);
>>> +
>>>       for (i = 0; i < 4; i++) {
>>>           s->sar_active[i] = false;
>>>       }
>>> -- 
>>> 1.8.4.5
>>>
>>>
>