From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0Exz-0005Jv-Qa for qemu-devel@nongnu.org; Wed, 03 Jun 2015 16:08:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0Exy-0004x6-IF for qemu-devel@nongnu.org; Wed, 03 Jun 2015 16:08:47 -0400 Message-ID: <556F5EC3.9040800@redhat.com> Date: Wed, 03 Jun 2015 14:08:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433360659-1915-1-git-send-email-mreitz@redhat.com> <1433360659-1915-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1433360659-1915-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4Ah6J5aRIDgP4QW2vBNIif0SgVSr7Jb4p" Subject: Re: [Qemu-devel] [PATCH v3 01/38] block: Remove host floppy support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , John Snow , qemu-devel@nongnu.org, Stefan Hajnoczi , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4Ah6J5aRIDgP4QW2vBNIif0SgVSr7Jb4p Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/03/2015 01:43 PM, Max Reitz wrote: > It has been deprecated as of 2.3, so we can now remove it. >=20 > Signed-off-by: Max Reitz > --- > block/raw-posix.c | 228 ++-----------------------------------------= -------- > qapi/block-core.json | 9 +- > 2 files changed, 11 insertions(+), 226 deletions(-) Dropping is not backwards-compatible, but that was the whole point of deprecating it to make it obvious that we planned to do it. Reviewed-by: Eric Blake > @@ -2283,14 +2221,13 @@ static int hdev_create(const char *filename, Qe= muOpts *opts, > int64_t total_size =3D 0; > bool has_prefix; > =20 > - /* This function is used by all three protocol block drivers and t= herefore > - * any of these three prefixes may be given. > + /* This function is used by both protocol block drivers and theref= ore either > + * of these prefixes may be given. > * The return value has to be stored somewhere, otherwise this is = an error > * due to -Werror=3Dunused-value. */ > has_prefix =3D > strstart(filename, "host_device:", &filename) || > - strstart(filename, "host_cdrom:" , &filename) || > - strstart(filename, "host_floppy:", &filename); > + strstart(filename, "host_cdrom:" , &filename); Libvirt does not refer to 'host_floppy' anywhere, so that is also reassuring about dropping this ancient and seldom-used feature. > +++ b/qapi/block-core.json > @@ -215,10 +215,11 @@ > # @drv: the name of the block format used to open the backing device. = As of > # 0.14.0 this can be: 'blkdebug', 'bochs', 'cloop', 'cow', 'dmg'= , > # 'file', 'file', 'ftp', 'ftps', 'host_cdrom', 'host_device', > -# 'host_floppy', 'http', 'https', 'nbd', 'parallels', 'qcow', > +# 'http', 'https', 'nbd', 'parallels', 'qcow', > # 'qcow2', 'raw', 'tftp', 'vdi', 'vmdk', 'vpc', 'vvfat' > # 2.2: 'archipelago' added, 'cow' dropped > # 2.3: 'host_floppy' deprecated > +# 2.4: 'host_floppy' dropped Also nice to know this is not the first time we've dropped something that is now worthless. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4Ah6J5aRIDgP4QW2vBNIif0SgVSr7Jb4p Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVb17DAAoJEKeha0olJ0Nqcx8H/0a26X2gvEDuX9c+rw+b6q4i ViLJC4A53/+CwivKVr1CDsB01kLjYixjWQMuZsNn2BeuvE6fG/wPQio7OkuXiGz9 p78XwtbykajFsTOeWb0rk7eB3x7XHSlNAED+wIlXxVswGDcwqf8e1QdgdDy33lwV b/GUfI2BkLVBQvISsxAcNtqOEITmLeRkmSjZH+ooyC3SbNG0joCr77rENZhcSQ5S CHI8SNORE5szm4de0Oqz9/5CPiB1w+V4+vI+HqaMarW32rvcOnLrXfey2QhpzCM4 /zi6UakaU2Xnj+nMhfMx76j8rcI7x/PuOAFm7gV0d1iFVwYakdOIJqmNLJzU/6c= =BfM4 -----END PGP SIGNATURE----- --4Ah6J5aRIDgP4QW2vBNIif0SgVSr7Jb4p--