From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0FEh-0006t0-PE for qemu-devel@nongnu.org; Wed, 03 Jun 2015 16:26:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0FEg-0005Ta-Ua for qemu-devel@nongnu.org; Wed, 03 Jun 2015 16:26:03 -0400 Message-ID: <556F62D2.50804@redhat.com> Date: Wed, 03 Jun 2015 14:25:54 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433360659-1915-1-git-send-email-mreitz@redhat.com> <1433360659-1915-9-git-send-email-mreitz@redhat.com> In-Reply-To: <1433360659-1915-9-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7daDDmQ9xpNUURd0lIpJ371fBrjPfJ4kC" Subject: Re: [Qemu-devel] [PATCH v3 08/38] block: Invoke change media CB before NULLing drv List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , John Snow , qemu-devel@nongnu.org, Stefan Hajnoczi , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7daDDmQ9xpNUURd0lIpJ371fBrjPfJ4kC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/03/2015 01:43 PM, Max Reitz wrote: > In order to handle host device passthrough, some guest device models > may call blk_is_inserted() to check whether the medium is inserted on > the host, when checking the guest tray status. >=20 > This tray status is inquired by blk_dev_change_media_cb(); because > bdrv_is_inserted() (invoked by blk_is_inserted()) always returns 0 for > BDS with drv set to NULL, blk_dev_change_media_cb() should therefore be= > called before drv is set to NULL. >=20 > Signed-off-by: Max Reitz > --- > block.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7daDDmQ9xpNUURd0lIpJ371fBrjPfJ4kC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVb2LSAAoJEKeha0olJ0Nq9rkH/AqIh1AUNmkiTNR99IK2RRmR K3wNpORTr2oxHcCT4n0yFMG6J7J2vEC9KfiyHyonshfk4qGvwsV3EC/IigulaqO8 lfeNO74aRDCHyUTvpaq8EMNJQBQ/NQx5V/k0VDVl4O56wK13egHgHJizXlSDh7D6 VXRLtR8bC3n7FAsnxvgXs9HjN85DLz1hWaPhrIm+yKedq7gGT1GhM3dENlN2nyAr sBCKIhnQpjCOPnNTPTqpmtdUZ4uzZR5HsDWYXg6z7bkvuWoPNz3rsY7gOmZ73lO/ mWzoEH5qt9bB5oqZc5ha3II3/9Ez/7C+5cwbkHVOPc0EVl2FCBvZqhOys1uImO8= =krg8 -----END PGP SIGNATURE----- --7daDDmQ9xpNUURd0lIpJ371fBrjPfJ4kC--