From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54788)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Z0FeU-0004hs-F4
	for qemu-devel@nongnu.org; Wed, 03 Jun 2015 16:52:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Z0FeT-0001M4-K2
	for qemu-devel@nongnu.org; Wed, 03 Jun 2015 16:52:42 -0400
Message-ID: <556F6912.9080101@redhat.com>
Date: Wed, 03 Jun 2015 14:52:34 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1433360659-1915-1-git-send-email-mreitz@redhat.com>
	<1433360659-1915-15-git-send-email-mreitz@redhat.com>
In-Reply-To: <1433360659-1915-15-git-send-email-mreitz@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="aElSJ8w6xrgdmnxbaaHS2KQVcwHGhrwnU"
Subject: Re: [Qemu-devel] [PATCH v3 14/38] block: Move BlockAcctStats into
	BlockBackend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, John Snow <jsnow@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--aElSJ8w6xrgdmnxbaaHS2KQVcwHGhrwnU
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/03/2015 01:43 PM, Max Reitz wrote:
> As the comment above bdrv_get_stats() says, BlockAcctStats is something=

> which belongs to the device instead of each BlockDriverState. This patc=
h
> therefore moves it into the BlockBackend.

Again, Berto may want to eventually report stats for both BDS and BB,
but that can come later.  For now, this is reasonable refactoring.

>=20
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  block.c                   | 11 -----------
>  block/block-backend.c     |  5 ++++-
>  block/io.c                |  6 +++++-
>  block/qapi.c              | 24 ++++++++++++++----------
>  include/block/block.h     |  2 --
>  include/block/block_int.h |  3 ---
>  6 files changed, 23 insertions(+), 28 deletions(-)
>=20

Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--aElSJ8w6xrgdmnxbaaHS2KQVcwHGhrwnU
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJVb2kTAAoJEKeha0olJ0Nq2z8H/iQyUKnqatY3vciOspYC3gmq
pgTOmATxZnSldNBC5nIeqF7wEjAeUuXsRi25izjL25P6+GwrRHzhKm1J5ABHs/cN
IQrFmXXTsj1bXhXJ4kgQHOyFySY8fpgYxYM9VrXFtoJxsQAsxKPrioIzumsgPoG8
T8OgvzLzijjta1Oz3z2VToqog3SV6pszHSDtSQFvY5ZHAWmjyhjLRLt81ff4/0JT
NxUGNBny4Mj1hqZ6hPGfQjeb+D/WaajLCIPa3JHWTB7/Eozo1biZ+sd+9vXOxERi
kERS92ax0BChZCXv/7mW+x97cwEyqent4DbDMHftsCJwUC2FrhJa0OzUCvbBkhE=
=drK1
-----END PGP SIGNATURE-----

--aElSJ8w6xrgdmnxbaaHS2KQVcwHGhrwnU--