From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0GLc-0001MV-Qt for qemu-devel@nongnu.org; Wed, 03 Jun 2015 17:37:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0GLb-0000aK-Ka for qemu-devel@nongnu.org; Wed, 03 Jun 2015 17:37:16 -0400 Message-ID: <556F7380.5050409@redhat.com> Date: Wed, 03 Jun 2015 15:37:04 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433360659-1915-1-git-send-email-mreitz@redhat.com> <1433360659-1915-34-git-send-email-mreitz@redhat.com> In-Reply-To: <1433360659-1915-34-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o0XD5IrACOXDGGxBrtoXG2skQLn6tJN7C" Subject: Re: [Qemu-devel] [PATCH v3 33/38] qmp: Introduce blockdev-change-medium List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , John Snow , qemu-devel@nongnu.org, Stefan Hajnoczi , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --o0XD5IrACOXDGGxBrtoXG2skQLn6tJN7C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/03/2015 01:44 PM, Max Reitz wrote: > Introduce a new QMP command 'blockdev-change-medium' which is intended > to replace the 'change' command for block devices. The existing functio= n > qmp_change_blockdev() is accordingly renamed to > qmp_blockdev_change_medium(). >=20 > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > blockdev.c | 7 ++++--- > include/sysemu/blockdev.h | 2 -- > qapi-schema.json | 6 ++++-- > qapi/block-core.json | 23 +++++++++++++++++++++++ > qmp-commands.hx | 31 +++++++++++++++++++++++++++++++ > qmp.c | 2 +- > 6 files changed, 63 insertions(+), 8 deletions(-) >=20 > +++ b/qapi/block-core.json > @@ -1909,6 +1909,29 @@ > =20 > =20 > ## > +# @blockdev-change-medium: > +# > +# Changes the medium inserted into a block device by ejecting the curr= ent medium > +# and loading a new image file which is inserted as the new medium (th= is command > +# combines blockdev-open-tray, blockdev-remove-medium, blockdev-insert= -medium > +# and blockdev-close-tray). > +# > +# @device: block device name > +# > +# @filename: filename of the new image to be loaded > +# > +# @format: #optional, format to open the new image with (defa= ults to > +# the probed format) > +# > +# Since: 2.3 /me the temptation is strong to go back on my word in 26 - ...must resist= =2E.. :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --o0XD5IrACOXDGGxBrtoXG2skQLn6tJN7C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVb3OAAAoJEKeha0olJ0Nq8NcH/1hSnosTf+v200Hhwg8O9nFx v6PoGXQWW4VwF3aUgRkI/gT9ewMTSuMTY48DuuB6u3CKOmO4jwGE/GyZFcAkISHV THnFYY1mGmu1sV873n4GEAWlmsItYeQn5zyBXwjSfeFZ88g69lFkCnxc7QRhYIfG wp+K5wSgxwLWnm+pFRElgwEfMbIk6CGqlroIsOmmQh2KJMgkdj8mC1pwTtaDSc7E 2AHfpY1KSuJcNM8xVvKdVqyg0FJOrLUBmZvx6bFC0GGUSf8YW2brK2Aob5dB5bHf iF5Lo/GquvXBzVOdhJYedSWQ1FYy/k5UduGUaWf4h1LP+XGx37lfx6Xk7C71Dtg= =uiEQ -----END PGP SIGNATURE----- --o0XD5IrACOXDGGxBrtoXG2skQLn6tJN7C--