From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0GV8-0000Zs-Ll for qemu-devel@nongnu.org; Wed, 03 Jun 2015 17:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0GV7-00046G-Ki for qemu-devel@nongnu.org; Wed, 03 Jun 2015 17:47:06 -0400 Message-ID: <556F75D3.9050507@redhat.com> Date: Wed, 03 Jun 2015 15:46:59 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433360659-1915-1-git-send-email-mreitz@redhat.com> <1433360659-1915-39-git-send-email-mreitz@redhat.com> In-Reply-To: <1433360659-1915-39-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qxBW2lNIc48FNSLm4oIpF8L6m4sHAGv1Q" Subject: Re: [Qemu-devel] [PATCH v3 38/38] iotests: Add test for change-related QMP commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , John Snow , qemu-devel@nongnu.org, Stefan Hajnoczi , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qxBW2lNIc48FNSLm4oIpF8L6m4sHAGv1Q Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/03/2015 01:44 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/118 | 638 +++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/118.out | 5 + > tests/qemu-iotests/group | 1 + > 3 files changed, 644 insertions(+) > create mode 100755 tests/qemu-iotests/118 > create mode 100644 tests/qemu-iotests/118.out >=20 > + def test_tray_open_change(self): > + result =3D self.vm.qmp('blockdev-open-tray', device=3D'drive0'= , force=3DTrue) > + self.assert_qmp(result, 'return', {}) > + > + self.wait_for_open() > + > + result =3D self.vm.qmp('query-block') > + self.assert_qmp(result, 'return[0]/tray_open', True) > + if self.was_empty =3D=3D True: Stylistically, isn't 'if self.was_empty:' equivalent? But I'm no python guru, so I can live with the test as you have it. > +++ b/tests/qemu-iotests/group > @@ -121,6 +121,7 @@ > 114 rw auto quick > 115 rw auto > 116 rw auto quick > +118 rw auto > 121 rw auto Wow - we've got several placeholders pending review :) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qxBW2lNIc48FNSLm4oIpF8L6m4sHAGv1Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVb3XTAAoJEKeha0olJ0NqwEwIAIikJeyqr3kjrkBgBQ0gENxd hm/5ILoztB51Zga6vmDLDBKQpWgb6MnWVwYAsXYmlgXpesRm45ntkwmBE84fiPZg wIuGaP/nsyI/kLCT7Ij6C+ruQ9IiElynfseq+0aYjwGxWh1Poy7F+tsQ4yboliMJ OeB8voFVpCJTk8BMxc16rf7UeJej8ghWhSv+8SXOHuNGaHB9VFoe5K098NdYSub9 nVj5b7U60ieZsQOHlGZuaLhWp90iKA7ChNcxSPV63tJoM5nBQx2Gsx+O2Zo22tAD r9CXHU5julP9VWyefVrKmO+aPchtgOQGZ9HaZ1cABa+T2gK3cgenZMlzSCt1+nw= =iTiA -----END PGP SIGNATURE----- --qxBW2lNIc48FNSLm4oIpF8L6m4sHAGv1Q--