From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0Gne-0003uM-Vh for qemu-devel@nongnu.org; Wed, 03 Jun 2015 18:06:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0Gna-0005Yd-EG for qemu-devel@nongnu.org; Wed, 03 Jun 2015 18:06:14 -0400 Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]:36501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0GnZ-0005YE-Ur for qemu-devel@nongnu.org; Wed, 03 Jun 2015 18:06:10 -0400 Received: by pabqy3 with SMTP id qy3so15533418pab.3 for ; Wed, 03 Jun 2015 15:06:09 -0700 (PDT) Sender: Richard Henderson Message-ID: <556F7A4C.60303@twiddle.net> Date: Wed, 03 Jun 2015 15:06:04 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1433365796-1118-1-git-send-email-aurelien@aurel32.net> <1433365796-1118-16-git-send-email-aurelien@aurel32.net> In-Reply-To: <1433365796-1118-16-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 15/16] target-s390x: use softmmu functions for mvcp/mvcs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org Cc: Alexander Graf On 06/03/2015 02:09 PM, Aurelien Jarno wrote: > mvcp and mvcs helper get access to the physical memory by a call to > mmu_translate for the virtual to real conversion and then using ldb_phys > and stb_phys to physically access the data. In practice this is quite > slow because it bypasses the QEMU softmmu TLB and because stb_phys calls > try to invalidate the corresponding memory for each access. > > Instead use cpu_ldb_{primary,secondary} for the loads and > cpu_stb_{primary,secondary} for the stores. Ideally this should be > further optimized by a call to memcpy, but that already improves the > boot time of a guest by a factor 1.8. > > Cc: Alexander Graf > Cc: Richard Henderson > Signed-off-by: Aurelien Jarno > --- > target-s390x/mem_helper.c | 53 ++++++++++++++++++----------------------------- > 1 file changed, 20 insertions(+), 33 deletions(-) Reviewed-by: Richard Henderson r~