From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Z0NHZ-0001Tc-8O
	for qemu-devel@nongnu.org; Thu, 04 Jun 2015 01:01:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Z0NHW-0005xB-3h
	for qemu-devel@nongnu.org; Thu, 04 Jun 2015 01:01:33 -0400
Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]:36347)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Z0NHV-0005vs-ST
	for qemu-devel@nongnu.org; Thu, 04 Jun 2015 01:01:30 -0400
Received: by pabqy3 with SMTP id qy3so21482211pab.3
	for <qemu-devel@nongnu.org>; Wed, 03 Jun 2015 22:01:29 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <556FDBA4.8070002@twiddle.net>
Date: Wed, 03 Jun 2015 22:01:24 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1432510638-21021-1-git-send-email-aurelien@aurel32.net>
	<1432510638-21021-3-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1432510638-21021-3-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/8] target-sh4: Split out T from SR
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org

On 05/24/2015 04:37 PM, Aurelien Jarno wrote:
> @@ -174,6 +176,16 @@ void superh_cpu_dump_state(CPUState *cs, FILE *f,
>   		    env->delayed_pc);
>       }
>   }
> +static void gen_read_sr(TCGv dst)
> +{
> +    tcg_gen_or_i32(dst, cpu_sr, cpu_sr_t);
> +}

Watch the spacing.

>           /* MOVCO.L
> @@ -1558,8 +1523,7 @@ static void _decode_opc(DisasContext * ctx)
>           */
>           if (ctx->features & SH_FEATURE_SH4A) {
>               TCGLabel *label = gen_new_label();
> -            tcg_gen_andi_i32(cpu_sr, cpu_sr, ~(1u << SR_T));
> -	    tcg_gen_or_i32(cpu_sr, cpu_sr, cpu_ldst);
> +            tcg_gen_mov_i32(cpu_sr, cpu_ldst);

Move to cpu_sr_t.


r~