From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 3/8] target-sh4: optimize addc using add2
Date: Wed, 03 Jun 2015 22:03:34 -0700 [thread overview]
Message-ID: <556FDC26.9090302@twiddle.net> (raw)
In-Reply-To: <1432510638-21021-4-git-send-email-aurelien@aurel32.net>
On 05/24/2015 04:37 PM, Aurelien Jarno wrote:
> - TCGv t0, t1;
> - t0 = tcg_temp_new();
> + TCGv t0, t1, t2;
> + t0 = tcg_const_tl(0);
> t1 = tcg_temp_new();
> - tcg_gen_add_i32(t0, REG(B7_4), REG(B11_8));
> - tcg_gen_add_i32(t1, cpu_sr_t, t0);
> - tcg_gen_setcond_i32(TCG_COND_GTU, cpu_sr_t, REG(B11_8), t0);
> - tcg_gen_setcond_i32(TCG_COND_GTU, t0, t0, t1);
> - tcg_gen_or_i32(cpu_sr_t, cpu_sr_t, t0);
> + t2 = tcg_temp_new();
> + tcg_gen_add2_i32(t1, t2, REG(B11_8), t0, REG(B7_4), t0);
> + tcg_gen_add2_i32(REG(B11_8), cpu_sr_t, t1, t2, cpu_sr_t, t0);
Swap these two adds and you don't need t2. You can consume sr_t immediately
and start producing it in the same go.
r~
next prev parent reply other threads:[~2015-06-04 5:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-24 23:37 [Qemu-devel] [PATCH v3 0/8] target-sh4: optimizations and cleanups Aurelien Jarno
2015-05-24 23:37 ` [Qemu-devel] [PATCH v3 1/8] target-sh4: use bit number for SR constants Aurelien Jarno
2015-05-24 23:37 ` [Qemu-devel] [PATCH v3 2/8] target-sh4: Split out T from SR Aurelien Jarno
2015-06-04 5:01 ` Richard Henderson
2015-05-24 23:37 ` [Qemu-devel] [PATCH v3 3/8] target-sh4: optimize addc using add2 Aurelien Jarno
2015-06-04 5:03 ` Richard Henderson [this message]
2015-06-04 10:54 ` Paolo Bonzini
2015-06-04 16:08 ` Aurelien Jarno
2015-05-24 23:37 ` [Qemu-devel] [PATCH v3 4/8] target-sh4: optimize subc using sub2 Aurelien Jarno
2015-06-04 5:05 ` Richard Henderson
2015-05-24 23:37 ` [Qemu-devel] [PATCH v3 5/8] target-sh4: optimize negc using add2 and sub2 Aurelien Jarno
2015-06-04 5:07 ` Richard Henderson
2015-05-24 23:37 ` [Qemu-devel] [PATCH v3 6/8] target-sh4: split out Q and M from of SR and optimize div1 Aurelien Jarno
2015-06-04 5:31 ` Richard Henderson
2015-05-24 23:37 ` [Qemu-devel] [PATCH v3 7/8] target-sh4: factorize fmov implementation Aurelien Jarno
2015-05-24 23:37 ` [Qemu-devel] [PATCH v3 8/8] target-sh4: remove dead code Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556FDC26.9090302@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).