From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: Martin Schrodt <martin@schrodt.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO
Date: Wed, 27 Jun 2018 15:15:32 +0200 [thread overview]
Message-ID: <556c60ab-8cd9-1f4c-e507-2d25fb580843@redhat.com> (raw)
In-Reply-To: <20180627111319.4mlws52yq5ldoxwe@sirius.home.kraxel.org>
On 27/06/2018 13:13, Gerd Hoffmann wrote:
> Hi,
>
>> Given the code runs under big qemu lock anyway the atomics are not
>> needed, so we could drop just them. I left them in nevertheless because
>>
>> (a) we might want try run the code in a thread instead of using a timer, and
>> (b) I was too lazy to rewrite the code to drop the atomics.
>>
>> I'd prefer to keep option (a) ...
>
> Well, experimented with that a bit.
>
> As long as the core audio system runs using qemu timers too moving to a
> thread doesn't buy us much as any latency spikes in qemu will hit us no
> matter what.
>
> So, that point is moot. I'll go drop the atomics.
Try stat64. It should work just fine as it's made exactly for this kind
of simple counter.
Paolo
next prev parent reply other threads:[~2018-06-27 13:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 13:12 [Qemu-devel] [PULL 0/6] Audio 20180625 patches Gerd Hoffmann
2018-06-25 13:12 ` [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO Gerd Hoffmann
2018-06-26 19:55 ` Max Reitz
2018-06-27 6:51 ` Gerd Hoffmann
2018-06-27 7:24 ` Thomas Huth
2018-06-27 7:57 ` [Qemu-devel] Drop support for 32bit hosts in qemu? (was: [PULL 1/6] audio/hda: create millisecond timers that handle IO) Markus Armbruster
2018-06-27 8:09 ` [Qemu-devel] Drop support for 32bit hosts in qemu? Thomas Huth
2018-06-27 8:56 ` Gerd Hoffmann
2018-06-27 11:08 ` Alex Bennée
2018-06-27 11:09 ` Thomas Huth
2018-06-27 8:15 ` [Qemu-devel] Drop support for 32bit hosts in qemu? (was: [PULL 1/6] audio/hda: create millisecond timers that handle IO) BALATON Zoltan
2018-06-27 8:52 ` Gerd Hoffmann
2018-06-27 9:09 ` Thomas Huth
2018-06-27 13:33 ` Philippe Mathieu-Daudé
2018-06-27 15:41 ` Laurent Vivier
2018-06-27 18:44 ` Dr. David Alan Gilbert
2018-06-27 19:55 ` Laurent Vivier
2018-06-27 10:49 ` Peter Maydell
2018-06-27 11:09 ` Dr. David Alan Gilbert
2018-06-27 13:08 ` Alex Bennée
2018-06-27 13:09 ` Alex Bennée
2018-06-27 11:09 ` Daniel P. Berrangé
2018-06-27 13:03 ` Alex Bennée
2018-06-27 13:38 ` Philippe Mathieu-Daudé
2018-06-27 13:02 ` [Qemu-devel] Drop support for 32bit hosts in qemu? Juan Quintela
2018-06-27 13:11 ` Daniel P. Berrangé
2018-06-27 11:13 ` [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO Gerd Hoffmann
2018-06-27 13:15 ` Paolo Bonzini [this message]
2018-06-27 12:21 ` Eric Blake
2018-06-29 8:19 ` Peter Maydell
2018-06-29 15:11 ` Eric Blake
2018-06-25 13:12 ` [Qemu-devel] [PULL 2/6] audio/hda: turn some dprintfs into trace points Gerd Hoffmann
2018-06-25 13:12 ` [Qemu-devel] [PULL 3/6] audio/hda: tweak timer adjust logic Gerd Hoffmann
2018-06-25 13:12 ` [Qemu-devel] [PULL 4/6] audio/hda: detect output buffer overruns Gerd Hoffmann
2018-06-25 13:12 ` [Qemu-devel] [PULL 5/6] audio/hda: enable new timer code by default Gerd Hoffmann
2018-06-25 13:12 ` [Qemu-devel] [PULL 6/6] audio: Convert use of atoi to qemu_strtoi Gerd Hoffmann
2018-06-25 15:37 ` [Qemu-devel] [PULL 0/6] Audio 20180625 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556c60ab-8cd9-1f4c-e507-2d25fb580843@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=martin@schrodt.org \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).