From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0QsK-00064M-Tp for qemu-devel@nongnu.org; Thu, 04 Jun 2015 04:51:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0QsH-0007D4-Oy for qemu-devel@nongnu.org; Thu, 04 Jun 2015 04:51:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0QsH-0007Cl-JT for qemu-devel@nongnu.org; Thu, 04 Jun 2015 04:51:41 -0400 Message-ID: <55701197.4060200@redhat.com> Date: Thu, 04 Jun 2015 10:51:35 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1432184528-31252-1-git-send-email-bharata@linux.vnet.ibm.com> <20150529022715.GB597@in.ibm.com> <20150604030854.GA32292@in.ibm.com> <557007A0.9010204@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/3] Bitmap based CPU enumeration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: zhugh.fnst@cn.fujitsu.com, Eduardo Habkost , "qemu-devel@nongnu.org Developers" , Alexander Graf , Bharata B Rao , Igor Mammedov , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , David Gibson On 04/06/2015 10:39, Peter Crosthwaite wrote: >> > I wouldn't mind separating the "CPU" parts of exec.c and moving them >> > under Andreas and Eduardo's mantainership. In fact, Peter, in your >> > patch to move stuff from cpu-exec.c to cpus.c, perhaps you can use >> > qom/cpu.c instead? Then qom/cpu.c can also be the place where we can >> > move the CPU parts of exec.c. >> > > So that relocated code uses conditional compile based on > CONFIG_SOFTMMU. Is that def accessible from common-obj-y code which > qom/cpu.c is? > > My choice of cpus.c was based on the fact that it was obj-y. Hmm, right---qom/cpu.c is indeed common-obj-y, so it has to be a new file. cpu-exec.c is taken, so I guess I'll move the memory parts of exec.c out to exec-memory.c and leave exec.c for the obj-y part of CPU object handling. We have: - cpu-exec.c: TCG only, arch-obj-y - cpus.c: thread management, obj-y - exec.c: CPU object management, obj-y - qom/cpu.c: CPU object management, common-obj-y And you can move the stuff from cpu-exec.c to exec.c in your patches. > I assume this is all follow up work out of scope of Bharata's code. Do > you have a queue I can rebase my conflicting ENV_GET_CPU work on? No, I don't, because I'm not going to be the one who merge these patches. Sorry. Paolo