From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0WUg-0002yg-6A for qemu-devel@nongnu.org; Thu, 04 Jun 2015 10:51:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0WUc-0003yP-U7 for qemu-devel@nongnu.org; Thu, 04 Jun 2015 10:51:42 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:32790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0WUc-0003yA-OO for qemu-devel@nongnu.org; Thu, 04 Jun 2015 10:51:38 -0400 Received: by padj3 with SMTP id j3so31125664pad.0 for ; Thu, 04 Jun 2015 07:51:37 -0700 (PDT) Message-ID: <557065ED.7010409@linaro.org> Date: Thu, 04 Jun 2015 22:51:25 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1432972477-13504-1-git-send-email-zhaoshenglong@huawei.com> <1432972477-13504-3-git-send-email-zhaoshenglong@huawei.com> <55705E46.4010106@msgid.tls.msk.ru> <55706108.9070903@linaro.org> <55706186.5070701@msgid.tls.msk.ru> In-Reply-To: <55706186.5070701@msgid.tls.msk.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/7] hw/mips/mips_jazz.c: Store irq array in MachineState to fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , Shannon Zhao , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org On 2015/6/4 22:32, Michael Tokarev wrote: > 04.06.2015 17:30, Shannon Zhao wrote: > >>> >>BTW, there's also cpu_exit_irq in this function whose allocation also >>> >>suffers from qemu_allocate_irqs(..., 1) API abuse. >> > >> >Yeah, missed this one. > This one isn't that simple, because it passes the result to DMA_init > which expects a pointer, even if it uses only one element of the > array. Yeah, but I think something like below would work. cpu_exit_irq = &qemu_allocate_irq(cpu_request_exit, NULL, 0); DMA_init(0, cpu_exit_irq); -- Shannon