From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0Wln-0001zt-Fk for qemu-devel@nongnu.org; Thu, 04 Jun 2015 11:09:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0Wlk-0001yZ-Il for qemu-devel@nongnu.org; Thu, 04 Jun 2015 11:09:23 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:34153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0Wlk-0001yI-EK for qemu-devel@nongnu.org; Thu, 04 Jun 2015 11:09:20 -0400 Received: by pdbki1 with SMTP id ki1so32825274pdb.1 for ; Thu, 04 Jun 2015 08:09:19 -0700 (PDT) Message-ID: <55706A17.80601@linaro.org> Date: Thu, 04 Jun 2015 23:09:11 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1432972477-13504-1-git-send-email-zhaoshenglong@huawei.com> <1432972477-13504-3-git-send-email-zhaoshenglong@huawei.com> <55705E46.4010106@msgid.tls.msk.ru> <55706108.9070903@linaro.org> <55706186.5070701@msgid.tls.msk.ru> <557065ED.7010409@linaro.org> <55706775.7090204@msgid.tls.msk.ru> In-Reply-To: <55706775.7090204@msgid.tls.msk.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/7] hw/mips/mips_jazz.c: Store irq array in MachineState to fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , Shannon Zhao , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org On 2015/6/4 22:57, Michael Tokarev wrote: > 04.06.2015 17:51, Shannon Zhao wrote: >> >Yeah, but I think something like below would work. >> > >> > cpu_exit_irq = &qemu_allocate_irq(cpu_request_exit, NULL, 0); >> > DMA_init(0, cpu_exit_irq); > NO!!!:) Hmm...really? This is used by DMA_schedule. void DMA_schedule(int nchan) { struct dma_cont *d = &dma_controllers[nchan > 3]; qemu_irq_pulse(*d->cpu_request_exit); } -- Shannon