From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0dLZ-00038A-SM for qemu-devel@nongnu.org; Thu, 04 Jun 2015 18:10:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0dLW-0004fr-I2 for qemu-devel@nongnu.org; Thu, 04 Jun 2015 18:10:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0dLW-0004fl-A1 for qemu-devel@nongnu.org; Thu, 04 Jun 2015 18:10:42 -0400 Message-ID: <5570CCDA.7010803@redhat.com> Date: Thu, 04 Jun 2015 16:10:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <557068F1.1030400@m2r.biz> <5570CA50.3080206@Gmail.com> In-Reply-To: <5570CA50.3080206@Gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5r1OX3Aahk0v9tLi16km4vdN2vQ7LTF6C" Subject: Re: [Qemu-devel] [Xen-devel] qemu mainline regression with xen-unstable: unable to start QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Don Slutz , Fabio Fantoni , "qemu-devel@nongnu.org" , xen-devel , Stefano Stabellini , Anthony PERARD , Ian Campbell , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5r1OX3Aahk0v9tLi16km4vdN2vQ7LTF6C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [adding Markus, as author of the regression] On 06/04/2015 03:59 PM, Don Slutz wrote: > On 06/04/15 11:04, Fabio Fantoni wrote: >> Today after trying xen-unstable build (tested many hours) of some days= >> ago I tried update qemu to latest development version (from git master= >> commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there = is >> a regression: >>> xl create /etc/xen/W7.cfg >>> Parsing config from /etc/xen/W7.cfg >>> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an >>> error message from QMP server: QMP input object member 'id' is unexpe= cted >>> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connec= t >>> to QMP >> >=20 > This is caused by: >=20 > commit 65207c59d99f2260c5f1d3b9c491146616a522aa > Author: Markus Armbruster > Date: Thu Mar 5 14:35:26 2015 +0100 >=20 > monitor: Drop broken, unused asynchronous command interface >=20 > The patch: >=20 >>>From 1b0221078353870fe530e49de158cae205f9bce5 Mon Sep 17 00:00:00 2001 > From: Don Slutz > Date: Thu, 4 Jun 2015 17:04:42 -0400 > Subject: [PATCH 01/14] monitor: Allow Xen's (broken) usage of asynchron= ous > command interface. >=20 > commit 65207c59d99f2260c5f1d3b9c491146616a522aa > Author: Markus Armbruster > Date: Thu Mar 5 14:35:26 2015 +0100 >=20 > monitor: Drop broken, unused asynchronous command interface >=20 > Breaks Xen. Add a hack un unbreak it. s/un /to / >=20 > Xen is only doing synchronous commands, but is including an id. QMP also uses id, but apparently removes it up front before calling into this function; so another fix would be having xen remove it up front. >=20 > Signed-off-by: Don Slutz > --- > monitor.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/monitor.c b/monitor.c > index c7baa91..e9a0747 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4955,6 +4955,15 @@ static QDict *qmp_check_input_obj(QObject > *input_obj, Error **errp) > "arguments", "object"); > return NULL; > } > + } else if (!strcmp(arg_name, "id")) { > + /* > + * Fixup Xen's usage. Just ignore the "id". See point #5 > + * above. This was an attempt at an asynchronous > + * command interface. However commit > + * 65207c59d99f2260c5f1d3b9c491146616a522aa is > + * wrong. Xen does not expect an error when it passes in > + * "id":1, so just continue to ignore it. > + */ The comment is a bit verbose, particularly since 'id' is a well-established usage pattern in QMP. Also, we don't need to call out why it changed in the comment here, the commit message is sufficient for that. > } else { > error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name); > return NULL; >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5r1OX3Aahk0v9tLi16km4vdN2vQ7LTF6C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVcMzaAAoJEKeha0olJ0NqT04IAIfUudpCG6RY6/ZVCpcF5l/u EjgvPO9KzDtJVO6u5yTsRfNOPSv8r70gtY4w/A22lBF42t2qgvqJVmuFi3sJfZMm ZfF11Ug9npZqBK4QJxliS2J5Ljp4PXC65EwfAJhcM4MaPN3gBzcLE+0gbZSQNjGM 8Kt1rSj1AEW5NIBr1MJ2gztVbFRr0/cCPwSpqPsU98kdoNQetqwOuMV+AgBOGHrV G3/kMc0DxLez4u0DmjjmJmFHKryfMc+ow0dttCNgLsChJDYIhysY0mXWn08LE5Hw DHgouFbROty7z5o0+5wkrJiJviKSDjWPZD351Hwr1iUe4vGN8MsoEwRsTI5oNzw= =Ojtk -----END PGP SIGNATURE----- --5r1OX3Aahk0v9tLi16km4vdN2vQ7LTF6C--