From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0hSz-0002X6-O0 for qemu-devel@nongnu.org; Thu, 04 Jun 2015 22:34:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0hSy-0004Ch-Mi for qemu-devel@nongnu.org; Thu, 04 Jun 2015 22:34:41 -0400 Message-ID: <55710AB3.8030804@redhat.com> Date: Thu, 04 Jun 2015 20:34:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433463642-21840-1-git-send-email-jsnow@redhat.com> <1433463642-21840-2-git-send-email-jsnow@redhat.com> In-Reply-To: <1433463642-21840-2-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tnXjhkWhrxeXhE8tSfHDfOvfSev5tlbA5" Subject: Re: [Qemu-devel] [PATCH 1/9] qapi: Rename 'dirty-bitmap' mode to 'incremental' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tnXjhkWhrxeXhE8tSfHDfOvfSev5tlbA5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/04/2015 06:20 PM, John Snow wrote: > If we wish to make differential backups a feature that's easy to access= , > it might be pertinent to rename the "dirty-bitmap" mode to "incremental= " > to make it clear what /type/ of backup the dirty-bitmap is helping us > perform. >=20 > This is an API breaking change, but 2.4 has not yet gone live, > so we have this flexibility. Agreed - I like the new name, and you are right that NOW is the time to do it. >=20 > Signed-off-by: John Snow > --- > block/backup.c | 10 +++++----- > block/mirror.c | 4 ++-- > docs/bitmaps.md | 8 ++++---- > include/block/block_int.h | 2 +- > qapi/block-core.json | 8 ++++---- > qmp-commands.hx | 6 +++--- > tests/qemu-iotests/124 | 10 +++++----- > 7 files changed, 24 insertions(+), 24 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tnXjhkWhrxeXhE8tSfHDfOvfSev5tlbA5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVcQqzAAoJEKeha0olJ0Nqei8H/jAI5VvjYAi84kUoKD90RXHa ax3enQZEoBZmQ9gvl3FH5R8C8dnNKrWrLu3sVenQCM+ZKFvj9auV2O+GKiQYnjlF GimpMU4eN4lk/w3qOzUJcepAKQ+48Uv2QJKKZcECh1gyRYHDxnpdam1c/ZRDRuwR oxxj0jwTF1KiYwhUhqJEKxFJpq7LBeA1zZiQiiDM4aAM3axdRXNynzLB355U7avu Wfr21u4K7doTyS+FU18nNE3eS9Yazgf3tUZ2gOTlziEPzass36yiMoQYAQLe2HiW TvqTD/F/DC0qg/jI+cpl5Jcgit2IufTe+yLR+qpNEwxJjunE3BtHb9GUFOB3YbA= =hSLv -----END PGP SIGNATURE----- --tnXjhkWhrxeXhE8tSfHDfOvfSev5tlbA5--