From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0sqP-0001DJ-4w for qemu-devel@nongnu.org; Fri, 05 Jun 2015 10:43:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0sqO-0005Q6-9X for qemu-devel@nongnu.org; Fri, 05 Jun 2015 10:43:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60875 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0sqO-0005Q2-3a for qemu-devel@nongnu.org; Fri, 05 Jun 2015 10:43:36 -0400 Message-ID: <5571B591.6050408@suse.de> Date: Fri, 05 Jun 2015 23:43:29 +0900 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/4] translate-all: Change tb_flush env argument to cpu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org, rth@twiddle.net Cc: Paolo Bonzini , Riku Voipio , Eduardo Habkost , Peter Crosthwaite Am 25.05.2015 um 15:22 schrieb Peter Crosthwaite: [...] > diff --git a/target-alpha/sys_helper.c b/target-alpha/sys_helper.c > index ae2e174..302cc1f 100644 > --- a/target-alpha/sys_helper.c > +++ b/target-alpha/sys_helper.c > @@ -74,7 +74,7 @@ void helper_tbis(CPUAlphaState *env, uint64_t p) > =20 > void helper_tb_flush(CPUAlphaState *env) > { > - tb_flush(env); > + tb_flush(ENV_GET_CPU(env)); Please do not use ENV_GET_CPU() in target code, here and below (compare the previous cleanup commits). Otherwise looks great. Regards, Andreas > } > =20 > void helper_halt(uint64_t restart) > diff --git a/target-i386/translate.c b/target-i386/translate.c > index 723e0cb..920aca4 100644 > --- a/target-i386/translate.c > +++ b/target-i386/translate.c > @@ -6925,7 +6925,7 @@ static target_ulong disas_insn(CPUX86State *env, = DisasContext *s, > gen_debug(s, pc_start - s->cs_base); > #else > /* start debug */ > - tb_flush(env); > + tb_flush(ENV_GET_CPU(env)); > qemu_set_log(CPU_LOG_INT | CPU_LOG_TB_IN_ASM); > #endif > break; [snip] --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)