From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0srZ-0002Dt-4Z for qemu-devel@nongnu.org; Fri, 05 Jun 2015 10:44:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0srV-0005df-1c for qemu-devel@nongnu.org; Fri, 05 Jun 2015 10:44:49 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60949 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0srU-0005dY-RU for qemu-devel@nongnu.org; Fri, 05 Jun 2015 10:44:44 -0400 Message-ID: <5571B5D7.8050105@suse.de> Date: Fri, 05 Jun 2015 23:44:39 +0900 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <08ddb7bd6de0b2ffa95f5d4e7b9e0082746e427e.1432534114.git.crosthwaite.peter@gmail.com> In-Reply-To: <08ddb7bd6de0b2ffa95f5d4e7b9e0082746e427e.1432534114.git.crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/4] gdbserver: _fork: Change fn to accept cpu instead of env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: Riku Voipio , Peter Crosthwaite , rth@twiddle.net Am 25.05.2015 um 15:22 schrieb Peter Crosthwaite: > All callsites to this function navigate the cpu->env_ptr only for the > function to take the env ptr back to the original cpu ptr. Change the > function to just pass in the CPU pointer instead. Removes a core code > usage of ENV_GET_CPU (in gdbstub.c). >=20 > Cc: Riku Voipio > Signed-off-by: Peter Crosthwaite > --- > bsd-user/main.c | 2 +- > gdbstub.c | 3 +-- > include/exec/gdbstub.h | 2 +- > linux-user/main.c | 2 +- > 4 files changed, 4 insertions(+), 5 deletions(-) Great, Reviewed-by: Andreas F=E4rber Thanks, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)