From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0sup-0003dl-Fq for qemu-devel@nongnu.org; Fri, 05 Jun 2015 10:48:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0sul-0007xB-DK for qemu-devel@nongnu.org; Fri, 05 Jun 2015 10:48:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:32892 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0sul-0007x7-6q for qemu-devel@nongnu.org; Fri, 05 Jun 2015 10:48:07 -0400 Message-ID: <5571B6A1.2010809@suse.de> Date: Fri, 05 Jun 2015 23:48:01 +0900 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <6c2b2815082aaab8580d79cc529150d46c417eaf.1432534114.git.crosthwaite.peter@gmail.com> In-Reply-To: <6c2b2815082aaab8580d79cc529150d46c417eaf.1432534114.git.crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/4] cpus: Change tcg_cpu_exec arg to cpu, not env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Crosthwaite , rth@twiddle.net Am 25.05.2015 um 15:22 schrieb Peter Crosthwaite: > The sole caller of this function navigates the cpu->env_ptr only for > this function to take it back the cpu pointer straight away. Pass in > cpu pointer instead and grab the env pointer locally in the function. > Removes a core code usage of ENV_GET_CPU. Please follow the convention of writing "foo()" for any function or parameterized macro, here and elsewhere. >=20 > Signed-off-by: Peter Crosthwaite > --- > cpus.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Andreas F=E4rber Thanks, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)