From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0syV-0005Hp-1z for qemu-devel@nongnu.org; Fri, 05 Jun 2015 10:52:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0syR-0001rn-JH for qemu-devel@nongnu.org; Fri, 05 Jun 2015 10:51:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33014 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0syR-0001ri-Cp for qemu-devel@nongnu.org; Fri, 05 Jun 2015 10:51:55 -0400 Message-ID: <5571B77D.1070202@suse.de> Date: Fri, 05 Jun 2015 23:51:41 +0900 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] cpus: Change exec_init arg to cpu, not env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org, Eduardo Habkost Cc: Peter Maydell , Jia Liu , Peter Crosthwaite , Bastian Koppelmann , Anthony Green , Bharata B Rao , Mark Cave-Ayland , Alexander Graf , Blue Swirl , Max Filippov , Michael Walle , "Edgar E. Iglesias" , Paolo Bonzini , Guan Xuetao , Leon Alrae , Aurelien Jarno , rth@twiddle.net Am 25.05.2015 um 15:22 schrieb Peter Crosthwaite: > The callers (most of them in target-foo/cpu.c) to this function all > have the cpu pointer handy. Just pass it to avoid an ENV_GET_CPU from > core code (in exec.c). >=20 > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Peter Maydell > Cc: "Edgar E. Iglesias" > Cc: "Andreas F=C3=A4rber" > Cc: Eduardo Habkost > Cc: Michael Walle > Cc: Aurelien Jarno > Cc: Leon Alrae > Cc: Anthony Green > Cc: Jia Liu > Cc: Alexander Graf > Cc: Blue Swirl > Cc: Mark Cave-Ayland > Cc: Bastian Koppelmann > Cc: Guan Xuetao > Cc: Max Filippov > Signed-off-by: Peter Crosthwaite > --- > exec.c | 4 ++-- > include/exec/exec-all.h | 2 +- > target-alpha/cpu.c | 2 +- > target-arm/cpu.c | 2 +- > target-cris/cpu.c | 2 +- > target-i386/cpu.c | 2 +- > target-lm32/cpu.c | 2 +- > target-m68k/cpu.c | 2 +- > target-microblaze/cpu.c | 2 +- > target-mips/cpu.c | 2 +- > target-moxie/cpu.c | 2 +- > target-openrisc/cpu.c | 2 +- > target-ppc/translate_init.c | 2 +- > target-s390x/cpu.c | 2 +- > target-sh4/cpu.c | 2 +- > target-sparc/cpu.c | 2 +- > target-tricore/cpu.c | 2 +- > target-unicore32/cpu.c | 2 +- > target-xtensa/cpu.c | 2 +- > 19 files changed, 20 insertions(+), 20 deletions(-) Reviewed-by: Andreas F=C3=A4rber I assume this will conflict with another patch adding an Error** argument - Eduardo, please help coordinating this. Thanks, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)