From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56820)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Z0tDB-0003wo-Hl
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 11:07:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Z0tDA-0001ne-KF
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 11:07:09 -0400
Message-ID: <5571BB13.4040304@redhat.com>
Date: Fri, 05 Jun 2015 17:06:59 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1433360659-1915-1-git-send-email-mreitz@redhat.com>
	<1433360659-1915-27-git-send-email-mreitz@redhat.com>
	<556F7095.1090800@redhat.com>
In-Reply-To: <556F7095.1090800@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 26/38] blockdev: Add blockdev-open-tray
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Markus Armbruster <armbru@redhat.com>

On 03.06.2015 23:24, Eric Blake wrote:
> On 06/03/2015 01:44 PM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> ---
>>   blockdev.c           | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>>   qapi/block-core.json | 23 +++++++++++++++++++++++
>>   qmp-commands.hx      | 39 +++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 110 insertions(+)
>>
>> +++ b/qapi/block-core.json
>> @@ -1836,6 +1836,29 @@
>>   ##
>>   { 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } }
>>   
>> +##
>> +# @blockdev-open-tray:
>> +#
>> +# Opens a block device's tray. If there is a block driver state tree inserted as
>> +# a medium, it will become inaccessible to the guest (but it will remain
>> +# associated to the block device, so closing the tray will make it accessible
>> +# again).
>> +#
>> +# If the tray was already open before, this will be a no-op.
>> +#
>> +# @device: block device name
>> +#
>> +# @force:  #optional if false (the default), an eject request will be sent to
>> +#          the guest if it has locked the tray (and the tray will not be opened
>> +#          immediately); if true, the tray will be opened regardless of whether
>> +#          it is locked
>> +#
>> +# Since: 2.3
> s/2.3/2.4/ - you'll probably have to make the change throughout the
> series (so I won't point it out further)

Oops, right. Thanks.

Max