From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0tmn-0007XM-RY for qemu-devel@nongnu.org; Fri, 05 Jun 2015 11:43:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0tmk-0000xb-Ct for qemu-devel@nongnu.org; Fri, 05 Jun 2015 11:43:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0tmk-0000xN-7b for qemu-devel@nongnu.org; Fri, 05 Jun 2015 11:43:54 -0400 Message-ID: <5571C3B4.2020906@redhat.com> Date: Fri, 05 Jun 2015 09:43:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <02aa01d09f9a$5bb198d0$1314ca70$@samsung.com> In-Reply-To: <02aa01d09f9a$5bb198d0$1314ca70$@samsung.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mC5XbIS7krMCHDlO3LGHR3L078hSFacul" Subject: Re: [Qemu-devel] [PATCH] Do not fail if id field is present. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Fedin , qemu-devel@nongnu.org Cc: 'Markus Armbruster' This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mC5XbIS7krMCHDlO3LGHR3L078hSFacul Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/05/2015 08:17 AM, Pavel Fedin wrote: > This fixes QMP regression: > http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html >=20 > Signed-off-by: Pavel Fedin > --- > monitor.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/monitor.c b/monitor.c > index c7baa91..ef21bba 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4955,6 +4955,8 @@ static QDict *qmp_check_input_obj(QObject *input_= obj, Error **errp) > "arguments", "object"); > return NULL; > } > + } else if (!strcmp(arg_name, "id")) { > + /* Ignored, necessary for backwards compatibility */ I think a better comment would be: /* Specially handled elsewhere to be included in reply to user */ But I agree that we need something like this patch to avoid a regression of causing QERR_QMP_EXTRA_MEMBER, since "id" is a documented part of the protocol. We also have other patches floating for the same issue: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01488.html that differ only in the choice of comment. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mC5XbIS7krMCHDlO3LGHR3L078hSFacul Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVccO0AAoJEKeha0olJ0NqyZYH/3XfKeIujBT0gz9fDqzFJiu3 RJBm5c46qAoYi6bZ6d/2rYmUpGrNeRzcum9de8bgcLDV/ejtrBon7dc7QBJoDddd hNoK85nxjPCzRH4DvI7b1SYYjo60XjjNlBLVeKagStS5QBMgFbtzIQhZxVTx+lhF rtdm1mplwylcsYNgbWwNOrBQNL8xdj4ypMN21n3altssKu6egRJxlEbZ9H1tg4ve 7PJNE69b1lLklKn//NnDpnLrrTrLLb+ToyGezR6QmO6jVJLec9tq9+ab189DRkm+ pvrZcxHpnujDRPJelj8LHeNiBU7iJXpxlCIP0xfG45adtT5+HTlKSdXnKub305k= =rMgc -----END PGP SIGNATURE----- --mC5XbIS7krMCHDlO3LGHR3L078hSFacul--