From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] qcow2: mark the memory as no longer needed after qcow2_cache_empty()
Date: Fri, 05 Jun 2015 17:47:33 +0200 [thread overview]
Message-ID: <5571C495.5000809@redhat.com> (raw)
In-Reply-To: <d30e8f156f1e9c246cf1db805d140bab19d98798.1433247225.git.berto@igalia.com>
On 02.06.2015 14:22, Alberto Garcia wrote:
> After having emptied the cache, the data in the cache tables is no
> longer useful, so we can tell the kernel that we are done with it. In
> Linux this frees the resources associated with it.
>
> The effect of this can be seen in the HMP commit operation: it moves
> data from the top to the base image (and fills both caches), then it
> empties the top image. At this point the data in that cache is no
> longer needed so it's just wasting memory.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> Cc: Max Reitz <mreitz@redhat.com>
> ---
> block/qcow2-cache.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2015-06-05 15:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 12:22 [Qemu-devel] [PATCH v5 0/4] Clean unused entries in the qcow2 L2/refcount cache Alberto Garcia
2015-06-02 12:22 ` [Qemu-devel] [PATCH 1/4] qcow2: mark the memory as no longer needed after qcow2_cache_empty() Alberto Garcia
2015-06-05 15:47 ` Max Reitz [this message]
2015-06-02 12:22 ` [Qemu-devel] [PATCH 2/4] qcow2: add option to clean unused cache entries after some time Alberto Garcia
2015-06-05 15:48 ` Max Reitz
2015-06-02 12:22 ` [Qemu-devel] [PATCH 3/4] docs: document how to configure the qcow2 L2/refcount caches Alberto Garcia
2015-06-05 15:52 ` Max Reitz
2015-06-05 15:56 ` Alberto Garcia
2015-06-05 16:00 ` Max Reitz
2015-06-05 16:05 ` Alberto Garcia
2015-06-05 16:13 ` Max Reitz
2015-06-02 12:22 ` [Qemu-devel] [PATCH 4/4] qcow2: reorder fields in Qcow2CachedTable to reduce padding Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5571C495.5000809@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).